Bug 42261 - #if !PLATFORM(CG) a bit confusing as a mechanism to decide how to handle ImageBuffer colorspace conversion
Summary: #if !PLATFORM(CG) a bit confusing as a mechanism to decide how to handle Imag...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 42228
Blocks:
  Show dependency tree / graph
 
Reported: 2010-07-14 07:37 PDT by Alex Nicolaou
Modified: 2014-05-12 05:51 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Nicolaou 2010-07-14 07:37:06 PDT 
In https://bugs.webkit.org/show_bug.cgi?id=42228#c11 Darin complained that the way we're deciding to do the colorspace conversion or not at the call sites that get pixels from an ImageBuffer that isn't in device colorspace is confusing. We could fix this by adding some other #define to key off of or by burying the decision making in the ImageBuffer class itself; this bug is meant for us to pick an approach so that I can implement it.
Comment 1 Alex Nicolaou 2010-07-14 07:37:26 PDT 
Add backlink to bug 42228
Comment 2 Dirk Schulze 2014-05-12 05:51:12 PDT 
It is not decided at caller site anymore.