Bug 42210 – [chromium] Autofill menu shows seperator at the wrong place when an entry is deleted

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Scott Violet]

- Trigger the autofill popup in a form text input where you have autofill and autocomplete values.
- In the popup, select the autocomplete value and press the delete key

Expected:
The selected entry is deleted and the menu shows the remaining entries, the separator and "Autofill options"

Actual:
The selected entry is deleted but "Autofill options" menu shows before the separator and if selected fills the text input with the actula "Autofill options" string

[Scott Violet]

Created attachment 61430 [details]
Initial fix

[James Hawkins]

LGTM

[David Levin]

Comment on attachment 61430 [details]
Initial fix

> Index: ChangeLog
> +        * ../../WebKit/chromium/src/AutoFillPopupMenuClient.cpp:
>
A few probloems:
1. The is either the wrong ChangeLog or else this patch is malformed. It should be the ChangeLog at WebKit/chromium/ChangeLog.
2. The path in the ChangeLog is messed up.
3. The function being modified is missing in the ChangeLog.
My bad if I missed any of these things before.


Lastly,it is nice to give a *small* comment by the function in the ChangeLog to explain what was done. (It looks like the change involves account for the separator index.)

[Scott Violet]

Created attachment 61539 [details]
Addresses review feedback

Adds call to popupmenuclient to make sure the removal is allowed. Without this the WebViewClient was notified even if the remove wasn't allowed.

[James Hawkins]

Patch set 2 LGTM, much better.

[David Holloway]

LGTM.

[WebKit Commit Bot]

Comment on attachment 61539 [details]
Addresses review feedback

Clearing flags on attachment: 61539

Committed r63395: <http://trac.webkit.org/changeset/63395>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.