Bug 42207 – Clean up interface to compile executables, always check for exceptions.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

Presently interface to compile executable is inconsistent between eval/program and function code, and is error prone in allowing a caller to byte compile without JIT compiling an executable (we rely on all executables with codeblocks having JIT code).  Unify on an interface where all compilation is performed by a single compile (with ForCall|ForConstruct variants) method, and make all clients check for errors.

[Gavin Barraclough]

Created attachment 61423 [details]
The patch

[WebKit Review Bot]

Attachment 61423 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/runtime/Executable.cpp:144:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/interpreter/Interpreter.cpp:3713:  vm_throw is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/interpreter/Interpreter.cpp:3874:  vm_throw is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/interpreter/Interpreter.cpp:4202:  vm_throw is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 4 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Oliver Hunt]

Comment on attachment 61423 [details]
The patch

verify this works with the interpreter enabled before landing. including the jit+interpreter mode :D

[Gavin Barraclough]

fixed in r63267, tested working in interpreter & JIT, could not get interpreter+JIT to work on the baseline.