Bug 42206 - [chromium] autofill suggestion popup should show the entire text
Summary: [chromium] autofill suggestion popup should show the entire text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 14:51 PDT by Jay Civelli
Modified: 2010-07-14 19:16 PDT (History)
4 users (show)

See Also:

Attachments
Initial patch (1.37 KB, patch)
2010-07-13 14:58 PDT, Jay Civelli 		no flags Details | Formatted Diff | Diff
Patch for landing (1.60 KB, patch)
2010-07-14 10:17 PDT, Jay Civelli 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Civelli 2010-07-13 14:51:04 PDT 
To ensure that users do not fill a form with information they do not realized they specified, the autofill suggestion popup should show the entire text (right now it limits the popup width to the text input width).
Comment 1 Jay Civelli 2010-07-13 14:58:55 PDT 
Created attachment 61421 [details]
Initial patch
Comment 2 James Hawkins 2010-07-13 15:00:33 PDT 
LGTM
Comment 3 WebKit Review Bot 2010-07-13 15:01:00 PDT 
Attachment 61421 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:163:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 David Levin 2010-07-13 15:30:29 PDT 
Comment on attachment 61421 [details]
Initial patch


> Index: WebKit/chromium/src/WebViewImpl.cpp
> +    false,  // restrictWidthOfListBox (for security reasons show the entire
> +            // entry so the user doesn't enter information it did not intend to)

Please consider starting with a capital letter "For security..." and ending with a period " did no intend to."
Comment 5 Jay Civelli 2010-07-14 10:17:01 PDT 
Created attachment 61532 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2010-07-14 19:16:40 PDT 
Comment on attachment 61532 [details]
Patch for landing

Clearing flags on attachment: 61532

Committed r63391: <http://trac.webkit.org/changeset/63391>
Comment 7 WebKit Commit Bot 2010-07-14 19:16:45 PDT 
All reviewed patches have been landed.  Closing bug.