Safari 5 fails 2d.path.stroke.prune.curve
Created attachment 61874 [details] Patch
Comment on attachment 61874 [details] Patch >WebCore/html/canvas/CanvasRenderingContext2D.cpp:562 > + Stray whitespace. >WebCore/html/canvas/CanvasRenderingContext2D.cpp:599 > + Ditto. >WebCore/html/canvas/CanvasRenderingContext2D.cpp:613 > + Ditto. >WebCore/html/canvas/CanvasRenderingContext2D.cpp:563 > + FloatRect boundRect = m_path.boundingRect(); It's a bit sad that we have to do this, getting the boundingRect() can be rather expensive. Qt will cache its results internally and reuse them when stroking/filling the path later on, but other back-ends may not be so lucky. Unfortunately I don't have a better suggestion. ;(
Created attachment 61896 [details] Patch
Comment on attachment 61896 [details] Patch Normally we keep style changes in separate patches. But the rest seems sensible to me, and Andreas Kling has had a look as well, so r=me.
Comment on attachment 61896 [details] Patch Rejecting patch 61896 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Last 500 characters of output: Core/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/html/canvas/CanvasRenderingContext2D.cpp Hunk #5 FAILED at 621. Hunk #6 succeeded at 646 (offset 2 lines). 1 out of 6 hunks FAILED -- saving rejects to file WebCore/html/canvas/CanvasRenderingContext2D.cpp.rej patching file WebCore/platform/graphics/cg/PathCG.cpp patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/mac/Skipped Hunk #1 succeeded at 211 (offset -2 lines). Full output: http://queues.webkit.org/results/3588225
Created attachment 61986 [details] Previous Patch (without extra whitespace deletion) Ugh, it looks like deleting some whitespace in one of the otherwise untouched methods causes svn-apply to fail. Here's a new patch without those whitespace deletes that patches on my machine with no problem.
Comment on attachment 61986 [details] Previous Patch (without extra whitespace deletion) Clearing flags on attachment: 61986 Committed r63727: <http://trac.webkit.org/changeset/63727>
All reviewed patches have been landed. Closing bug.