Bug 42185 – Synchronize Khronos and WebKit WebGL tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

Many of the WebGL layout tests which originated in WebKit have been adopted as portions of the Khronos WebGL conformance suite. It is desirable to consider the Khronos repository the master version of these tests, because multiple vendors are making improvements to them in that repository. Recent changes to the WebKit layout tests have been merged into the Khronos version of the tests. At this point we need to synchronize the Khronos versions of the WebKit WebGL layout tests back to the WebKit repository, to get back to a state where the tests are identical (modulo some paths of .js includes which are different in the two repositories).

This synchronization will be done in a few stages because it will touch a lot of test code. This bug will be used to track the progress.

[Zhenyao Mo]

(In reply to comment #0)
> Many of the WebGL layout tests which originated in WebKit have been adopted as portions of the Khronos WebGL conformance suite. It is desirable to consider the Khronos repository the master version of these tests, because multiple vendors are making improvements to them in that repository. Recent changes to the WebKit layout tests have been merged into the Khronos version of the tests. At this point we need to synchronize the Khronos versions of the WebKit WebGL layout tests back to the WebKit repository, to get back to a state where the tests are identical (modulo some paths of .js includes which are different in the two repositories).
> 
> This synchronization will be done in a few stages because it will touch a lot of test code. This bug will be used to track the progress.

Maybe we should change the folder structure in khronos conformance tests to match the WebKit Layout tests.  That way we can do a full sync with very little effort.

[Kenneth Russell]

(In reply to comment #1)
> Maybe we should change the folder structure in khronos conformance tests to match the WebKit Layout tests.  That way we can do a full sync with very little effort.

This would require the creation of some unnecessary directories in the Khronos test suite. I think that we can get the same effect with a simple shell script to perform the synchronization -- which I will probably add while fixing this bug.

[Kenneth Russell]

Created attachment 61695 [details]
Patch

From the ChangeLog:

For the WebGL tests in the Khronos repository that originated in the WebKit repository, synchronized the latest versions of these tests using a script which will be checked in later. Copied webgl-test-utils.js from Khronos repo and added needed entry points to webgl-test.js. Rebaselined tests as necessary and verified the rebaselining manually.

[Kenneth Russell]

Created attachment 61698 [details]
Revised patch

Replaced tabs with spaces in Khronos repo in a couple of tests, and re-synchronized those tests.

[Kenneth Russell]

Committed r63444: <http://trac.webkit.org/changeset/63444>

[WebKit Review Bot]

http://trac.webkit.org/changeset/63444 might have broken Leopard Intel Release (Tests)