Bug 42180 - [chromium] Autofill popup menu is broken when cycling through all the suggestions
Summary: [chromium] Autofill popup menu is broken when cycling through all the suggest...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 11:14 PDT by Jay Civelli
Modified: 2010-07-14 16:02 PDT (History)
3 users (show)

See Also:

Attachments
Initial patch (1.36 KB, patch)
2010-07-13 11:34 PDT, Jay Civelli 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Civelli 2010-07-13 11:14:03 PDT 
- Bring up a form autofill or autocomplete popup in Chromium
- Arrow down so you pass all the suggestions and cycle back to the 1st one
- Press ESC to close the popup

Expected:
The popup is closed.

Actual:
The popup linger and cannot be closed anymore.

This was introduced by https://bugs.webkit.org/attachment.cgi?id=58439
Comment 1 Jay Civelli 2010-07-13 11:34:18 PDT 
Created attachment 61400 [details]
Initial patch

This is effectively a revert of https://bugs.webkit.org/show_bug.cgi?id=42180
That CL fixed a Chromium crasher: http://code.google.com/p/chromium/issues/detail?id=46287 that I cannot reproduce with this new code.
Comment 2 James Hawkins 2010-07-13 11:39:08 PDT 
LGTM. We'll keep an eye on the crashers and see if the original crash pops up again.
Comment 3 WebKit Commit Bot 2010-07-14 16:02:43 PDT 
Comment on attachment 61400 [details]
Initial patch

Clearing flags on attachment: 61400

Committed r63367: <http://trac.webkit.org/changeset/63367>
Comment 4 WebKit Commit Bot 2010-07-14 16:02:48 PDT 
All reviewed patches have been landed.  Closing bug.