Bug 42172 – [chromium] Tabbing away after you highlight an autofill entry results in the label for the autofill profile getting included in the field

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Scott Violet]

1. Go to "options -> personal stuff -> change autofill settings" and create
an address profile with the label "Home". Let the name be "John Doe"
2. Navigate to a web page with name and address fields.
3. Click in the empty first name field on the web page.
4. Hit the down arrow key on your keyboard until "John (Home)" is highlighted.
5. Hit the tab key on your keyboard to move to the next field.

What is the expected output? 
The first name field is filled with the text "John".

What do you see instead?
The first name field is filled with the text "John (Home)".

Additional information: If you click on "John (Home)" with your mouse, the
correct name is entered in the first name field. It is only when you tab
away from the selection that the label gets added to the name. It looks
like the Autofill++ entry is being treated like an Autofill classic entry
when you tab away from the field.

[Scott Violet]

Created attachment 61391 [details]
Makes tab commit selection

[WebKit Review Bot]

Attachment 61391 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/chromium/PopupMenuChromium.cpp:756:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Levin]

Comment on attachment 61391 [details]
Makes tab commit selection

r=me with two minor fixes to the comment:
1.Capitalize the first letter in the comment.
2.Only one space before the comment as the style bot noted.

(r- only b/c you aren't a committer.)

[Scott Violet]

Created attachment 61394 [details]
Fixes style nits and adds correct reviewer.

[WebKit Commit Bot]

Comment on attachment 61394 [details]
Fixes style nits and adds correct reviewer.

Clearing flags on attachment: 61394

Committed r63236: <http://trac.webkit.org/changeset/63236>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.