Bug 42168 - REGRESSION (r63192): Pixel test failure in contain-and-cover.html
Summary: REGRESSION (r63192): Pixel test failure in contain-and-cover.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 08:40 PDT by Pavel Podivilov
Modified: 2010-07-13 09:38 PDT (History)
3 users (show)

See Also:


Attachments
add contain-and-cover.html to test_expectations (1.05 KB, patch)
2010-07-13 08:51 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-07-13 08:40:41 PDT
contain-and-cover.html start failing after http://trac.webkit.org/changeset/63192, http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Linux%20(webkit.org)/builds/32026
Could you please have a look?
Comment 1 Jeremy Orlow 2010-07-13 08:47:55 PDT
Why am I cc'ed on this?  Also you really need to provide WAY more information to non-Chromium contributors.  There's basically no context here.  And no link to where he can see the actual failing test/results.  (Hopefully we'll be able to get pixel tests working on build.webkit.org soon!)
Comment 2 Pavel Podivilov 2010-07-13 08:51:02 PDT
Created attachment 61383 [details]
add contain-and-cover.html to test_expectations
Comment 3 Jeremy Orlow 2010-07-13 08:53:18 PDT
Is this a real regression?  If so (and you can't get ahold of Andreas) then you should revert it and not paper over the regression.  If it's not a real regression then you should probably go ahead and check in a new baseline.
Comment 4 Pavel Podivilov 2010-07-13 09:03:43 PDT
(In reply to comment #3)
> Is this a real regression?  If so (and you can't get ahold of Andreas) then you should revert it and not paper over the regression.  If it's not a real regression then you should probably go ahead and check in a new baseline.

I've cc'ed you just because you were in https://bugs.webkit.org/show_bug.cgi?id=38108 which seemed very similar to this problem. 

I'm not sure if it's a regression or not, that's why I've created this bug.
Comment 5 Andreas Kling 2010-07-13 09:09:53 PDT
Just a quick note to let you know I'm looking at this right now.
Comment 6 Pavel Podivilov 2010-07-13 09:15:08 PDT
(In reply to comment #5)
> Just a quick note to let you know I'm looking at this right now.

Andreas, it's my bad, this is actually the same problem as https://bugs.webkit.org/show_bug.cgi?id=38108, and absolutely not connected to r63192. For some reason image diff was first detected by buildbots just after your change.
Comment 7 Pavel Podivilov 2010-07-13 09:19:25 PDT

*** This bug has been marked as a duplicate of bug 38108 ***
Comment 8 Andreas Kling 2010-07-13 09:22:36 PDT
Not so fast, this actually did regress with my change (r63192). Didn't notice it since we don't have pixel tests for Qt. ;(
Working on a fix right now.
Comment 9 Pavel Podivilov 2010-07-13 09:29:41 PDT
If so, could you please revert it?

*** This bug has been marked as a duplicate of bug 38108 ***
Comment 10 Pavel Podivilov 2010-07-13 09:32:50 PDT
Duplicate -> Unconfirmed
Comment 11 Andreas Kling 2010-07-13 09:38:48 PDT
Reverted with <http://trac.webkit.org/changeset/63213>