Bug 42166 - Fix the constant encoding in data transfer instructions on ARM
Summary: Fix the constant encoding in data transfer instructions on ARM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P1 Major
Assignee: Gabor Loki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 07:50 PDT by Gabor Loki
Modified: 2010-07-13 12:17 PDT (History)
5 users (show)

See Also:


Attachments
Fix the constant encoding in data transfer instructions on ARM (4.13 KB, patch)
2010-07-13 07:52 PDT, Gabor Loki
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2010-07-13 07:50:26 PDT
The immediate constant encoding is differ between data transfer and data processing instructions on ARM.

The getImm function is designed to produce modified immediate constant for data processing instructions. So, we should not use it to encode any constant for data transfer.
Comment 1 Gabor Loki 2010-07-13 07:52:07 PDT
Created attachment 61375 [details]
Fix the constant encoding in data transfer instructions on ARM
Comment 2 Zoltan Herczeg 2010-07-13 09:17:33 PDT
Gabor, please mention the reporter in the ChangeLog.
Comment 3 Gabor Loki 2010-07-13 11:57:03 PDT
Committed revision 63228.
Comment 4 WebKit Review Bot 2010-07-13 12:17:19 PDT
http://trac.webkit.org/changeset/63228 might have broken GTK Linux 32-bit Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/63228
http://trac.webkit.org/changeset/63229