Bug 42163 - Add tests to check if WebSocket's challenge value is random
Summary: Add tests to check if WebSocket's challenge value is random
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 06:47 PDT by Yuta Kitamura
Modified: 2010-07-14 03:53 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.59 KB, patch)
2010-07-13 07:03 PDT, Yuta Kitamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2010-07-13 06:47:21 PDT
Chromium has a bug that it always sends a same challenge value due to inability to generate a random value in a worker process. We need to add a test to confirm whether the bug is fixed or not.

Original bug: http://crbug.com/47390
Comment 1 Yuta Kitamura 2010-07-13 07:03:42 PDT
Created attachment 61368 [details]
Patch
Comment 2 Alexey Proskuryakov 2010-07-13 09:42:42 PDT
Comment on attachment 61368 [details]
Patch

I don't think that requiring strict comparison is formally correct. Is there anything in specs that disallows MessageEvent.data return a String object?

r=me, since it's at least testing for our current behavior, and the behavior is unlikely to change.
Comment 3 Fumitoshi Ukai 2010-07-13 18:19:23 PDT
Comment on attachment 61368 [details]
Patch

LGTM
Comment 4 WebKit Commit Bot 2010-07-14 02:35:58 PDT
Comment on attachment 61368 [details]
Patch

Clearing flags on attachment: 61368

Committed r63298: <http://trac.webkit.org/changeset/63298>
Comment 5 WebKit Commit Bot 2010-07-14 02:36:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-07-14 03:39:54 PDT
http://trac.webkit.org/changeset/63298 might have broken Chromium Mac Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/63298
http://trac.webkit.org/changeset/63299
http://trac.webkit.org/changeset/63300
Comment 7 Fumitoshi Ukai 2010-07-14 03:53:13 PDT
(In reply to comment #6)
> http://trac.webkit.org/changeset/63298 might have broken Chromium Mac Release
> The following changes are on the blame list:
> http://trac.webkit.org/changeset/63298
> http://trac.webkit.org/changeset/63299
> http://trac.webkit.org/changeset/63300

63298 and 63299 add test only, so 63300 should be blamed.