Bug 42157 - [v8] Web Inspector: inspector front-end crashes upon JS exception in front-end callbacks
Summary: [v8] Web Inspector: inspector front-end crashes upon JS exception in front-en...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 05:41 PDT by Andrey Kosyakov
Modified: 2010-07-13 07:23 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.65 KB, patch)
2010-07-13 05:48 PDT, Andrey Kosyakov 		yurys: review-
yurys: commit-queue-
Details | Formatted Diff | Diff
patch (1.25 KB, patch)
2010-07-13 06:03 PDT, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2010-07-13 05:41:52 PDT 
Inspector front-end renderer crashes if a front-end callback (such as WebInspector.parsedScriptSource) throws a JS exception (e.g. due to JS syntax error).
Comment 1 Andrey Kosyakov 2010-07-13 05:48:36 PDT 
Created attachment 61359 [details]
patch
Comment 2 Yury Semikhatsky 2010-07-13 05:52:24 PDT 
Comment on attachment 61359 [details]
patch

WebKit/chromium/src/WebDevToolsFrontendImpl.cpp:179
 +      if (tryCatch.HasCaught()) {
You don't need this, just calling tryCatch.SetVerbose(true) should be enough.
Comment 3 Andrey Kosyakov 2010-07-13 06:03:52 PDT 
Created attachment 61362 [details]
patch
Comment 4 WebKit Commit Bot 2010-07-13 07:23:39 PDT 
Comment on attachment 61362 [details]
patch

Clearing flags on attachment: 61362

Committed r63201: <http://trac.webkit.org/changeset/63201>
Comment 5 WebKit Commit Bot 2010-07-13 07:23:43 PDT 
All reviewed patches have been landed.  Closing bug.