Bug 42153 - Activate test fonts for layout tests in WebKitTestRunner (on Mac)
Summary: Activate test fonts for layout tests in WebKitTestRunner (on Mac)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 02:51 PDT by Maciej Stachowiak
Modified: 2010-07-13 03:03 PDT (History)
1 user (show)

See Also:

Attachments
Patch (457.22 KB, patch)
2010-07-13 02:54 PDT, Maciej Stachowiak 		zimmermann: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2010-07-13 02:51:42 PDT 
Activate test fonts for layout tests in WebKitTestRunner (on Mac)
Comment 1 Maciej Stachowiak 2010-07-13 02:54:05 PDT 
Created attachment 61348 [details]
Patch
Comment 2 Nikolas Zimmermann 2010-07-13 02:59:48 PDT 
Comment on attachment 61348 [details]
Patch

WebKitTools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:28
 +  #import <CoreFoundation/CoreFoundation.h>
Can you sort the headers, or did you use this order on purpose?

WebKitTools/WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:32
 +      // not implemented
I'd prefer "// FIXME: Not implemented.".

Other than that, looks fine. r=me.
Comment 3 WebKit Review Bot 2010-07-13 03:00:06 PDT 
Attachment 61348 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Maciej Stachowiak 2010-07-13 03:03:10 PDT 
Committed r63187: <http://trac.webkit.org/changeset/63187>