RESOLVED FIXED 42153
Activate test fonts for layout tests in WebKitTestRunner (on Mac) 
https://bugs.webkit.org/show_bug.cgi?id=42153
Summary Activate test fonts for layout tests in WebKitTestRunner (on Mac)
Maciej Stachowiak
Reported 2010-07-13 02:51:42 PDT
Activate test fonts for layout tests in WebKitTestRunner (on Mac)
Attachments
Patch (457.22 KB, patch)
2010-07-13 02:54 PDT, Maciej Stachowiak 		zimmermann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2010-07-13 02:54:05 PDT
Created attachment 61348 [details] Patch
Nikolas Zimmermann
Comment 2 2010-07-13 02:59:48 PDT
Comment on attachment 61348 [details] Patch WebKitTools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:28 + #import <CoreFoundation/CoreFoundation.h> Can you sort the headers, or did you use this order on purpose? WebKitTools/WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:32 + // not implemented I'd prefer "// FIXME: Not implemented.". Other than that, looks fine. r=me.
WebKit Review Bot
Comment 3 2010-07-13 03:00:06 PDT
Attachment 61348 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Maciej Stachowiak
Comment 4 2010-07-13 03:03:10 PDT
Committed r63187: <http://trac.webkit.org/changeset/63187>
Note You need to log in before you can comment on or make changes to this bug.