Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
Created attachment 61316 [details] Patch
Attachment 61316 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/Scripts/old-run-webkit-tests:351: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:352: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1886: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1887: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1888: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1889: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1890: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1921: Line contains tab character. [whitespace/tab] [5] Total errors found: 8 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 61316 [details] Patch > > +if ($useWebKitTestRunner) { > + if (isAppleMacWebKit()) { > + $realPlatform = $platform; > + $platform = "mac-wk2"; > + } > +} Looks like a case of the "tabs." There are a few others of these. > +# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > +# > + > +# <https://bugs.webkit.org/show_bug.cgi?id=42130> WebKit2 needs to support accessibility > +# <https://bugs.webkit.org/show_bug.cgi?id=42131> WebKitTestRunner needs to support accessibility-related DRT APIs > +accessibility > \ No newline at end of file Need a newline. Other than that, r=me.
http://trac.webkit.org/changeset/63163