Bug 42122 - Adding directional property enums back into CSSComputedStyleDeclaration::getPropertyCSSValue
Summary: Adding directional property enums back into CSSComputedStyleDeclaration::getP...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Albert J. Wong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-12 17:51 PDT by Albert J. Wong
Modified: 2010-07-12 18:15 PDT (History)
1 user (show)

See Also:

Attachments
add enums back into switch. (1.86 KB, patch)
2010-07-12 17:57 PDT, Albert J. Wong 		jianli: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Albert J. Wong 2010-07-12 17:51:33 PDT 
Chromium build needs all enum values represented inside a switch statement or else it throws an error.

Adding in the enum values handled by resolveDirectionAwareProperty() into the switch statement with an ASSERT_NOT_REACHED() to make the compiler happy.
Comment 1 Albert J. Wong 2010-07-12 17:57:17 PDT 
Created attachment 61304 [details]
add enums back into switch.
Comment 2 Erik Arvidsson 2010-07-12 18:00:43 PDT 
Comment on attachment 61304 [details]
add enums back into switch.

Looks good with the following exception

+        Reviewed by NOBODY (OOPS!).

Change to "Unreviewed, build fix."
Comment 3 Jian Li 2010-07-12 18:12:23 PDT 
Comment on attachment 61304 [details]
add enums back into switch.

r=me

Generally looks good. Before landing your patch, please add more details to ChangeLog to describe why you need to add back enums.
Comment 4 Albert J. Wong 2010-07-12 18:15:35 PDT 
Landed as r63153 with beefed up changelog.

Resolving.