Bug 42113 - Chromium: not sending key down events to plugins
Summary: Chromium: not sending key down events to plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-12 14:42 PDT by Viet-Trung Luu
Modified: 2010-07-12 22:30 PDT (History)
5 users (show)

See Also:

Attachments
proposed patch (1.28 KB, patch)
2010-07-12 14:56 PDT, Viet-Trung Luu 		no flags Details | Formatted Diff | Diff
(hopefully) fixed patch (1.41 KB, application/octet-stream)
2010-07-12 15:52 PDT, Viet-Trung Luu 		no flags Details
patch again (1.41 KB, patch)
2010-07-12 15:53 PDT, Viet-Trung Luu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Viet-Trung Luu 2010-07-12 14:42:30 PDT 
Chromium isn't sending key down events to plugins. This was broken by r62743.
Comment 1 Viet-Trung Luu 2010-07-12 14:56:35 PDT 
Created attachment 61273 [details]
proposed patch
Comment 2 Adam Barth 2010-07-12 15:16:23 PDT 
Comment on attachment 61273 [details]
proposed patch

Clear Main Comment Box:8
 +          * ../../../../src/WebPluginContainerImpl.cpp:
This path is wrong.
Comment 3 Viet-Trung Luu 2010-07-12 15:52:14 PDT 
Created attachment 61278 [details]
(hopefully) fixed patch

The previous patch also had broken paths. Hopefully this one is okay.
Comment 4 John Abd-El-Malek 2010-07-12 15:53:14 PDT 
whoa, sorry about that.
Comment 5 Viet-Trung Luu 2010-07-12 15:53:24 PDT 
Created attachment 61279 [details]
patch again

Remembering to click the "patch" checkbox.
Comment 6 WebKit Commit Bot 2010-07-12 22:30:41 PDT 
Comment on attachment 61279 [details]
patch again

Clearing flags on attachment: 61279

Committed r63170: <http://trac.webkit.org/changeset/63170>
Comment 7 WebKit Commit Bot 2010-07-12 22:30:46 PDT 
All reviewed patches have been landed.  Closing bug.