Bug 42111 – [Chromium] "justify" alignment is not honored for complext script rendering in Linux

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Layout and Rendering

[Xiaomei Ji]

Open the attached html page in chrome.
Observe the text alignment.

The css style in the html page is "text-align:justify". So, the text should be justified.
Instead, the spaces is not evenly distributed and the text is not justified.

In Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=48873

[Xiaomei Ji]

Created attachment 61268 [details]
test case

[Xiaomei Ji]

Created attachment 61292 [details]
patch

Claire Ho who works on Android proposed this patch.
Since the complex script handling of Andriod is pretty much similar to that in Chromium Linux, the patch should apply to Chromium Linux as well.

On Claire's behalf, I am loading this patch for review.

I did not add new test, after the patch, pixel test result of one existing test will change in Linux, and it needs rebaseline from canary.

[WebKit Review Bot]

Attachment 61292 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/chromium/FontLinux.cpp:514:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/chromium/FontLinux.cpp:537:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/graphics/chromium/FontLinux.cpp:538:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/graphics/chromium/FontLinux.cpp:539:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Xiaomei Ji]

Created attachment 61293 [details]
patch

Claire Ho who works on Android proposed this patch.
Since the complex script handling of Andriod is pretty much similar to that in Chromium Linux, the patch should apply to Chromium Linux as well.

On Claire's behalf, I am loading this patch for review.

I did not add new test, after the patch, pixel test result of one existing test will change in Linux, and it needs rebaseline from canary.

[Adam Langley]

Comment on attachment 61293 [details]
patch

Please patch in the patch from https://bugs.webkit.org/show_bug.cgi?id=39014 and see if that fixes the issue.

[Xiaomei Ji]

*** This bug has been marked as a duplicate of bug 39014 ***