Bug 4207 - crash on a specific website
Summary: crash on a specific website
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Major
Assignee: Dave Hyatt
URL: http://wow-europe.com/en/info/underde...
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-29 13:37 PDT by Denis Ahrens
Modified: 2005-08-08 14:36 PDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Ahrens 2005-07-29 13:37:34 PDT
Safari (cvs-current from 29.7.2005) crashes when you click on an image on http://wow-europe.com/
en/info/underdev/darkmoon.html

It does not happen with the normal Safari browser, only with a cvs-build one!

The following fixes at least the crash!

diff -u -r1.99 htmlparser.cpp
--- htmlparser.cpp      18 Jul 2005 21:52:26 -0000      1.99
+++ htmlparser.cpp      29 Jul 2005 20:20:23 -0000
@@ -1360,7 +1360,7 @@
 void HTMLParser::finished()
 {
     // In the case of a completely empty document, here's the place to create the HTM
L element.
-    if (current->isDocumentNode() && current->firstChild() == 0) {
+    if (current && current->isDocumentNode() && current->firstChild() == 0) {
         insertNode(new HTMLHtmlElementImpl(document));
     }
Comment 1 Mark Rowe (bdash) 2005-08-06 23:21:32 PDT
A fix identical to the one described below was landed on 2005-08-04 so I am resolving this as fixed.  
Denis, can you please verify that the problem is resolved: if so, mark the bug as resolved, and if not please 
reopen it.
Comment 2 Denis Ahrens 2005-08-08 14:36:20 PDT
yes, it seems the crash is not only fixed but that now the new window actually displays some content 
which was not the case with the default Safari before.