Bug 42066 - [EFL] build error after applying changeset 63050
Summary: [EFL] build error after applying changeset 63050
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-12 02:48 PDT by Jaehun Lim
Modified: 2010-07-23 22:30 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.64 KB, patch)
2010-07-12 02:57 PDT, Jaehun Lim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaehun Lim 2010-07-12 02:48:53 PDT 
After applying changeset 63050, WebKit-EFL build can't find a "ScriptControllerBase.h" file.

For resolving this problem, "WebCore/bindings" should be added to the include path for WebCore and WebKit builds
Comment 1 Jaehun Lim 2010-07-12 02:57:53 PDT 
Created attachment 61201 [details]
patch

build error fix
Comment 2 Joone Hur 2010-07-14 03:24:16 PDT 
Hi Jaehun,  you started fixing bugs. :-)
You need to add reviewers and EFL guys to CC list.
Comment 3 Lucas De Marchi 2010-07-20 12:44:51 PDT 
Hi Jaehun. This was fixed in r63083.

Next time, put me and leandro as CC so we can apply patches from you without having to search on bugzilla for random bugs.
Comment 4 Daniel Bates 2010-07-23 22:30:46 PDT 
Comment on attachment 61201 [details]
patch

Clearing both the review flag and the commit-queue flag on this patch since a patch similar to this one <https://bugs.webkit.org/attachment.cgi?id=61201> was landed in changeset 63083 <http://trac.webkit.org/changeset/63083> as pointed out in Lucas De Marchi's comment <https://bugs.webkit.org/show_bug.cgi?id=42066#c3>. If this is a mistake then feel free to put the patch up for review and/or commit-queue again.