Bug 42065 - [V8] Opening inspector crashes the page when javascript is disabled
Summary: [V8] Opening inspector crashes the page when javascript is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-12 02:41 PDT by Pavel Podivilov
Modified: 2010-07-16 08:39 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch. (1.73 KB, patch)
2010-07-12 03:07 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-07-12 02:41:27 PDT
[V8] Opening inspector crashes the page when javascript is disabled
Comment 1 Pavel Podivilov 2010-07-12 03:07:36 PDT
Created attachment 61203 [details]
Proposed patch.
Comment 2 Yury Semikhatsky 2010-07-12 03:54:39 PDT
Comment on attachment 61203 [details]
Proposed patch.

Will it fix start profiling/evaluate in console/properties editing in Elements panel/running audits etc?
Comment 3 Pavel Podivilov 2010-07-12 04:55:53 PDT
(In reply to comment #2)
> (From update of attachment 61203 [details])
> Will it fix start profiling/evaluate in console/properties editing in Elements panel/running audits etc?

All this stuff seems to work fine except for accessing window/document from console (got errors like "TypeError: Expecting a function in instanceof check, but got [object DOMWindow]").
Comment 4 Yury Semikhatsky 2010-07-16 08:38:59 PDT
Comment on attachment 61203 [details]
Proposed patch.

Clearing flags on attachment: 61203

Committed r63550: <http://trac.webkit.org/changeset/63550>
Comment 5 Yury Semikhatsky 2010-07-16 08:39:09 PDT
All reviewed patches have been landed.  Closing bug.