Bug 42032 – Need to emulate MAX_VARYING_VECTORS/MAX_FRAGMENT_UNIFORM_VECTORs/MAX_VERTEX_UNIFORM_VECTORS for glGet

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Zhenyao Mo]

In desktop gl, the corresponding enums are MAX_VARYING_FLOATS/MAX_FRAGMENT_UNIFORM_COMPONENTS/MAX_VERTEX_UNIFORM_COMPONENTS.

The difference is a multitude of 4.

[Zhenyao Mo]

Created attachment 61162 [details]
patch

[Kenneth Russell]

Comment on attachment 61162 [details]
patch

Looks good to me.

[Darin Fisher (:fishd, Google)]

Comment on attachment 61162 [details]
patch

WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:1229
 +          *value /= 4;
nit: you should explain this factor of 4 in the ChangeLog.  desktop GL returns
byte counts or something, and GLES2 needs to return 32bit word counts?

R=me

[Zhenyao Mo]

(In reply to comment #3)
> (From update of attachment 61162 [details])
> WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:1229
>  +          *value /= 4;
> nit: you should explain this factor of 4 in the ChangeLog.  desktop GL returns
> byte counts or something, and GLES2 needs to return 32bit word counts?
> 
> R=me

Will add a comment in the landing patch.

[Zhenyao Mo]

Committed r63215: <http://trac.webkit.org/changeset/63215>

[WebKit Review Bot]

http://trac.webkit.org/changeset/63215 might have broken GTK Linux 64-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/63216
http://trac.webkit.org/changeset/63215