http://dev.w3.org/2006/webapi/WebTiming/#nt-redirect-start
Created attachment 61183 [details] Patch
Comment on attachment 61183 [details] Patch WebCore/loader/FrameLoaderTypes.h:64 + FrameLoadTimeline() i'm a little surprised to see this struct defined in this file. i always thought of this file as the place to put loader defined enums. normally, webkit has the style rule that you create a new file for each struct or class. WebCore/loader/MainResourceLoader.cpp:166 + frameLoadTimeline->redirectEnd = currentTime(); it might be good to call currentTime only once and then use that value for both redirectEnd and fetchStart. i think it is not wrong for them to be different, but it also seems ok (perhaps good) to say that they are exactly the same. R=me
Created attachment 61454 [details] Patch for landing
(In reply to comment #2) > (From update of attachment 61183 [details]) > WebCore/loader/FrameLoaderTypes.h:64 > + FrameLoadTimeline() > i'm a little surprised to see this struct defined in this file. > i always thought of this file as the place to put loader defined > enums. normally, webkit has the style rule that you create a > new file for each struct or class. > Noted. I added a FIXME to this patch and will move it out in a subsequent patch. > WebCore/loader/MainResourceLoader.cpp:166 > + frameLoadTimeline->redirectEnd = currentTime(); > it might be good to call currentTime only once and then use that value > for both redirectEnd and fetchStart. i think it is not wrong for them > to be different, but it also seems ok (perhaps good) to say that they > are exactly the same. Makes sense. Done. > > R=me
Comment on attachment 61454 [details] Patch for landing Rejecting patch 61454 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20685 test cases. fast/dom/Window/window-property-descriptors.html -> failed Exiting early after 1 failures. 6878 tests run. 120.45s total testing time 6877 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://webkit-commit-queue.appspot.com/results/3450296
Created attachment 61527 [details] Patch for landing
Comment on attachment 61527 [details] Patch for landing Clearing flags on attachment: 61527 Committed r63326: <http://trac.webkit.org/changeset/63326>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/63326 might have broken Qt Linux Release