Bug 42014 - Tidy up lexer token ids
Summary: Tidy up lexer token ids
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-09 17:54 PDT by Oliver Hunt
Modified: 2010-07-10 12:48 PDT (History)
4 users (show)

See Also:


Attachments
Patch (50.57 KB, patch)
2010-07-09 17:55 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (43.80 KB, patch)
2010-07-09 18:11 PDT, Oliver Hunt
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-07-09 17:54:14 PDT
Tidy up lexer token ids
Comment 1 Oliver Hunt 2010-07-09 17:55:51 PDT
Created attachment 61127 [details]
Patch
Comment 2 Darin Adler 2010-07-09 17:59:01 PDT
Comment on attachment 61127 [details]
Patch

You need to change parseEQUALmentExpression, m_EQUALmentCount, and initialEQUALments back.

Also, why do these token enum values all need TO SHOUT ALL THE TIME. I CAN HEAR THEM EVEN IN MIXED CASE.

Typically people do that with macros because they are so dangerous, but if they’re just normal C objects I suggest not using all capitals.
Comment 3 Oliver Hunt 2010-07-09 18:11:30 PDT
Created attachment 61130 [details]
Patch
Comment 4 Gavin Barraclough 2010-07-09 18:19:18 PDT
Comment on attachment 61130 [details]
Patch

r+, assuming you've convinced Darin that the level of SHOUTiness is okay.
Comment 5 Oliver Hunt 2010-07-09 18:26:22 PDT
Committed r63024
Comment 6 WebKit Review Bot 2010-07-09 19:07:30 PDT
http://trac.webkit.org/changeset/63024 might have broken Qt Linux Release minimal
The following changes are on the blame list:
http://trac.webkit.org/changeset/63024
http://trac.webkit.org/changeset/63025
Comment 7 Zoltan Herczeg 2010-07-09 23:38:49 PDT
Uh, this patch will conflict with my patch submitted two days ago:
https://bugs.webkit.org/show_bug.cgi?id=41845

I will resolve the conflict on Monday, but any thoughts welcome.
Comment 8 Oliver Hunt 2010-07-10 12:30:35 PDT
(In reply to comment #7)
> Uh, this patch will conflict with my patch submitted two days ago:
> https://bugs.webkit.org/show_bug.cgi?id=41845
> 
> I will resolve the conflict on Monday, but any thoughts welcome.

Argh, sorry i thought i had reviewed that :-(

I can have a look at resolving the conflicts if you want?
Comment 9 Zoltan Herczeg 2010-07-10 12:48:27 PDT
> I can have a look at resolving the conflicts if you want?

No need, thanks. This will be an easy task (hopefully). Will submit the patch on Monday.