Tidy up lexer token ids
Created attachment 61127 [details] Patch
Comment on attachment 61127 [details] Patch You need to change parseEQUALmentExpression, m_EQUALmentCount, and initialEQUALments back. Also, why do these token enum values all need TO SHOUT ALL THE TIME. I CAN HEAR THEM EVEN IN MIXED CASE. Typically people do that with macros because they are so dangerous, but if they’re just normal C objects I suggest not using all capitals.
Created attachment 61130 [details] Patch
Comment on attachment 61130 [details] Patch r+, assuming you've convinced Darin that the level of SHOUTiness is okay.
Committed r63024
http://trac.webkit.org/changeset/63024 might have broken Qt Linux Release minimal The following changes are on the blame list: http://trac.webkit.org/changeset/63024 http://trac.webkit.org/changeset/63025
Uh, this patch will conflict with my patch submitted two days ago: https://bugs.webkit.org/show_bug.cgi?id=41845 I will resolve the conflict on Monday, but any thoughts welcome.
(In reply to comment #7) > Uh, this patch will conflict with my patch submitted two days ago: > https://bugs.webkit.org/show_bug.cgi?id=41845 > > I will resolve the conflict on Monday, but any thoughts welcome. Argh, sorry i thought i had reviewed that :-( I can have a look at resolving the conflicts if you want?
> I can have a look at resolving the conflicts if you want? No need, thanks. This will be an easy task (hopefully). Will submit the patch on Monday.