Bug 42008 - TreeWalker::previousSibling calls firstChild instead of lastChild when handling FILTER_SKIP
Summary: TreeWalker::previousSibling calls firstChild instead of lastChild when handli...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-09 17:29 PDT by Craig Topper
Modified: 2019-02-06 09:02 PST (History)
2 users (show)

See Also:

Attachments
Test case (1.50 KB, text/html)
2010-07-12 21:58 PDT, Craig Topper 		no flags Details
Patch (10.99 KB, patch)
2010-07-14 14:14 PDT, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Topper 2010-07-09 17:29:23 PDT 
Need to start at the end of the children instead of the beginning. nextSibling correctly calls firstChild.
Comment 1 Darin Adler 2010-07-12 14:48:57 PDT 
Could you provide a test case?
Comment 2 Darin Adler 2010-07-12 14:53:51 PDT 
It does seem obvious from code inspection that this is broken, and replacing firstChild with lastChild should be all it takes to fix it; the test case is going to be the hardest part.
Comment 3 Craig Topper 2010-07-12 21:58:12 PDT 
Created attachment 61324 [details]
Test case
Comment 4 Darin Adler 2010-07-14 14:14:46 PDT 
Created attachment 61563 [details]
Patch
Comment 5 Darin Adler 2010-07-14 15:49:57 PDT 
Committed r63365: <http://trac.webkit.org/changeset/63365>
Comment 6 Lucas Forschler 2019-02-06 09:02:35 PST 
Mass moving XML DOM bugs to the "DOM" Component.