Bug 41988 - [QT] WebKit fails to build against Qt QPA / Lighthouse
Summary: [QT] WebKit fails to build against Qt QPA / Lighthouse
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P5 Enhancement
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-07-09 14:27 PDT by Jamey Hicks
Modified: 2011-07-25 04:43 PDT (History)
3 users (show)

See Also:

Attachments
patch to fix build against Qt Lighthouse/QPA (400 bytes, patch)
2010-07-09 14:27 PDT, Jamey Hicks 		no flags Details | Formatted Diff | Diff
patch to fix build against Qt Lighthouse/QPA (400 bytes, application/octet-stream)
2010-07-09 14:30 PDT, Jamey Hicks 		no flags Details
patch updated with changelog (1.03 KB, patch)
2010-07-12 06:18 PDT, Jamey Hicks 		hausmann: review-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jamey Hicks 2010-07-09 14:27:22 PDT 
Created attachment 61096 [details]
patch to fix build against Qt Lighthouse/QPA

If building WebKit against Qt Lighthouse with no X headers, then plugin support fails to compile. The attached patch adds embedded to CONFIG if qpa is in QT_CONFIG.
Comment 1 Jamey Hicks 2010-07-09 14:30:48 PDT 
Created attachment 61097 [details]
patch to fix build against Qt Lighthouse/QPA
Comment 2 Jamey Hicks 2010-07-12 06:18:32 PDT 
Created attachment 61218 [details]
patch updated with changelog

Added a ChangeLog
Comment 3 Simon Hausmann 2010-08-04 12:58:18 PDT 
Comment on attachment 61218 [details]
patch updated with changelog

Patch looks fine to me, but could you fix up the ChangeLog? :)

The indentation is off, there shouldn't be a "No new tests. (OOPS!)" line and maybe add a "[Qt]" suffix in front of the "enable build against Qt lighthouse" title.
Comment 4 Benjamin Poulain 2011-01-14 11:29:21 PST 
Closing, this seems outdated.

Feel free to submit an updated patch and I will be happy reopen the task.
Comment 5 Konstantin Tokarev 2011-07-25 04:43:59 PDT 
It's quite esy to forward-port this patch, but I don't agree with it. QPA does not mean "embedded" or "without X11"