Bug 41985 – rebaseline_chromium_webkit_tests missing --use_drt option on linux

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Albert J. Wong]

With r59743, a dependency was added on the use_drt option.  However, the option parser used in the linux entrypoint was left out of the update.  This caused this to break on linux.

[Albert J. Wong]

Created attachment 61091 [details]
Fix rebaseline_chromium_webkit_tests on linux by adding --use_drt option.

[Albert J. Wong]

Created attachment 61093 [details]
fixed up spacing + help message.

[Victor Wang]

The rebaseline tool should not depend on DRT or test shell, so think it is better not adding use_drt option to rebaseline tool. Maybe fix the chromium port scripts to check use_drt option exists (hasattr(options, 'use_drt')) before using it?

[David Levin]

Comment on attachment 61093 [details]
fixed up spacing + help message.

A few things that would be nice to fix before landing are below.

> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> [phone]  Albert J. Wong  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        rebaseline_chromium_webkit_tests missing --use_drt option on linux
> +        https://bugs.webkit.org/show_bug.cgi?id=41985
> +
> +        This add in the --use_drt option for into

s/add/adds/
s/for into/for/


> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py
> +    option_parser.add_option('', '--use_drt',
> +                             action='store_true',
> +                             default=False,
> +                             help=('Use ImageDiff from DumpRenderTree instead '
> +                                   'of image_diff for pixel tests'))

Add a . to the end of the sentence.

[Victor Wang]

(In reply to comment #2)
> Created an attachment (id=61093) [details]
> fixed up spacing + help message.

Look fine to me with your updated help message.

[Albert J. Wong]

landed as r62997