Bug 41968 – RenderSVGRoot::nodeAtPoint truncates translated mouse coordinates

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Fady Samuel]

Simple one line fix to webkit that's blocking another (chromium) bug I'm working on. localPoint is being stored in an IntPoint instead of a FloatPoint, which means we lose (a lot of) precision if the transform scales down the coordinates.

[Fady Samuel]

Created attachment 61065 [details]
One line fix localPoint in RenderSVGRoot::nodeAtPoint is now a FloatPoint instead of an IntPoint.

[Darin Adler]

Comment on attachment 61065 [details]
One line fix localPoint in RenderSVGRoot::nodeAtPoint is now a FloatPoint instead of an IntPoint.

Bug fixes need to include regression tests. Can you make and include a test for what this fixes?

[Fady Samuel]

Created attachment 63520 [details]
One line fix localPoint in RenderSVGRoot::nodeAtPoint is now a FloatPoint instead of an IntPoint.

Added a layout test.

[Fady Samuel]

Created attachment 63586 [details]
One line fix: localPoint in RenderSVGRoot::nodeAtPoint is now a FloatPoint instead of an IntPoint.

Fixed conflicting test_expectations file.

[Nikolas Zimmermann]

Comment on attachment 63586 [details]
One line fix: localPoint in RenderSVGRoot::nodeAtPoint is now a FloatPoint instead of an IntPoint.

r=me.

[Eric Seidel (no email)]

Comment on attachment 63520 [details]
One line fix localPoint in RenderSVGRoot::nodeAtPoint is now a FloatPoint instead of an IntPoint.

Cleared Darin Adler's review+ from obsolete attachment 63520 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[WebKit Commit Bot]

Comment on attachment 63586 [details]
One line fix: localPoint in RenderSVGRoot::nodeAtPoint is now a FloatPoint instead of an IntPoint.

Rejecting patch 63586 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Nikolas Zimmermann', u'--force']" exit_code: 1
Last 500 characters of output:
hangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium-mac/svg/hittest/svg-rect-hit-expected.txt
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 3181.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej
patching file LayoutTests/svg/hittest/svg-rect-hit.html
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/rendering/RenderSVGRoot.cpp

Full output: http://queues.webkit.org/results/3635418

[Adam Barth]

Created attachment 64077 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 64077 [details]
Patch for landing

Clearing flags on attachment: 64077

Committed r65172: <http://trac.webkit.org/changeset/65172>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Fady Samuel]

Created attachment 64275 [details]
Patch - Adds missing files

[Fady Samuel]

Bug was prematurely closed.

[Adam Barth]

Comment on attachment 64275 [details]
Patch - Adds missing files

Thanks.  Sorry for screwing up your patch earlier.  :-/

[WebKit Commit Bot]

Comment on attachment 64275 [details]
Patch - Adds missing files

Rejecting patch 64275 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20833 test cases.
svg/text/select-textLength-spacing-squeeze-3.svg -> failed

Exiting early after 1 failures. 18680 tests run.
402.01s total testing time

18679 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
261 test cases (1%) had stderr output

Full output: http://queues.webkit.org/results/3721096

[Eric Seidel (no email)]

Attachment 64275 [details] was posted by a committer and has review+, assigning to Fady Samuel for commit.

[Eric Seidel (no email)]

r65172.  Please use webkit-patch land so that bugs get closed when you land changes.