Bug 41964 – [chromium] popup menu should have the capability of showing labels

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jay Civelli]

For the Chromium autofill related feature, we need the PopupMenuChromium to be able to display a custom label on the right side for each entry.

[Jay Civelli]

Created attachment 61060 [details]
Initial patch

[WebKit Review Bot]

Attachment 61060 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/AutoFillPopupMenuClient.cpp:280:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
WebCore/platform/chromium/PopupMenuChromium.cpp:915:  One line control clauses should not use braces.  [whitespace/braces] [4]
WebCore/platform/chromium/PopupMenuChromium.cpp:961:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Attachment 61060 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/3507040

[Jay Civelli]

Created attachment 61115 [details]
Fixed style issues

[Eric Seidel (no email)]

Attachment 61115 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/3488087

[Kent Tamura]

Comment on attachment 61115 [details]
Fixed style issues

The code looks OK.  Please fix the build error:

/Users/eseidel/Projects/MacEWS/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/i386/RenderTextControlSingleLine.o
cc1plus: warnings being treated as errors
/Users/eseidel/Projects/MacEWS/WebCore/rendering/RenderTextControlSingleLine.cpp:879: warning: unused parameter 'listIndex'
distcc[99406] ERROR: compile /Users/eseidel/Projects/MacEWS/WebCore/rendering/RenderTextControlSingleLine.cpp on localhost failed


WebCore/platform/chromium/PopupMenuChromium.cpp:73
 +  static const int kTextToLabelPadding = 10;
nit: We don't prepend 'k' prefix to constant value symbols.  This change is ok for consistency.

[Jay Civelli]

Created attachment 61245 [details]
Fixing Mac build

[Kent Tamura]

Comment on attachment 61245 [details]
Fixing Mac build

WebKit/chromium/src/AutoFillPopupMenuClient.cpp:70
 +      if (index == -1)
I don't think this code works.  A compiler warns "signed vs. unsigned" and removes the code by optimization.
convertListIndexToInternalIndex() should return signed int.

[Jay Civelli]

Created attachment 61298 [details]
Changed  AutoFillPopupMenuClient::convertListIndexToInternalIndex to return a signed int

[Kent Tamura]

Comment on attachment 61298 [details]
Changed  AutoFillPopupMenuClient::convertListIndexToInternalIndex to return a signed int

OK.

[WebKit Commit Bot]

Comment on attachment 61298 [details]
Changed  AutoFillPopupMenuClient::convertListIndexToInternalIndex to return a signed int

Clearing flags on attachment: 61298

Committed r63179: <http://trac.webkit.org/changeset/63179>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/63179 might have broken Chromium Win Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/63178
http://trac.webkit.org/changeset/63179
http://trac.webkit.org/changeset/63180
http://trac.webkit.org/changeset/63181