--- Comment #10 from WebKit Commit Bot <eseidel@chromium.org> 2010-07-09 07:52:34 PST --- (From update of attachment 60910 [details]) Rejecting patch 60910 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 60910, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 68, in run if self._has_valid_reviewer(changelog_entry): File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer'
The problem turned out to be a stray line break at the top of the ChangeLog. I can put together a fix for this. Options are: 1. Automatically strip line breaks at the top of the ChangeLog 2. Just detect and warn in a more useful way 3. Ignore this bug as a user-error #1 seems the best to me. Thoughts?
> 1. Automatically strip line breaks at the top of the ChangeLog In which layer were you thinking of making this change? svn-apply already does some fixup of the ChangeLog so it might make sense there,