Bug 41935 - Add RuntimeEnabledFeatures::timeRangesEnabled() required by r62880
Summary: Add RuntimeEnabledFeatures::timeRangesEnabled() required by r62880
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Albert J. Wong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-09 00:16 PDT by Albert J. Wong
Modified: 2010-07-09 02:28 PDT (History)
0 users

See Also:

Attachments
Add in timeRangesEnable() (1.71 KB, patch)
2010-07-09 00:28 PDT, Albert J. Wong 		zimmermann: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Albert J. Wong 2010-07-09 00:16:49 PDT 
Revision 62880 made TimeRanges EnabledAtRuntime.  This requires a corresponding function, RuntimeEnabledFeatures::timeRangesEnabled(), to be added.
Comment 1 Albert J. Wong 2010-07-09 00:28:48 PDT 
Created attachment 61006 [details]
Add in timeRangesEnable()
Comment 2 Nikolas Zimmermann 2010-07-09 00:36:43 PDT 
Comment on attachment 61006 [details]
Add in timeRangesEnable()

LGTM, r=me.We were both not 100% sure whether timeRangesEnabled() should be 1:1 coupled with the MediaPlayer availability. But as TimeRanges is conditional=video, and it's also exposed only if VIDEO is enabled, it seems fine.
Comment 3 Albert J. Wong 2010-07-09 02:28:16 PDT 
Committed as r62920.