RESOLVED FIXED 41928
REGRESSION(r62887): printing/page-rule-selection.html is broken 
https://bugs.webkit.org/show_bug.cgi?id=41928
Summary REGRESSION(r62887): printing/page-rule-selection.html is broken
Adam Barth
Reported 2010-07-08 21:27:32 PDT
http://trac.webkit.org/changeset/62876 broke printing/page-rule-selection.html http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r62876%20(13247)/printing/page-rule-selection-pretty-diff.html --- /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/printing/page-rule-selection-expected.txt 2010-07-08 18:33:04.000000000 -0700 +++ /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/printing/page-rule-selection-actual.txt 2010-07-08 18:33:04.000000000 -0700 @@ -10,11 +10,11 @@ PASS layoutTestController.pageProperty('margin-left', 3) is "auto" PASS layoutTestController.pageProperty('margin-left', 4) is "auto" Set margin to 200px via user style sheet. -PASS layoutTestController.pageProperty('margin-left', 0) is "200" -PASS layoutTestController.pageProperty('margin-left', 1) is "200" -PASS layoutTestController.pageProperty('margin-left', 2) is "200" -PASS layoutTestController.pageProperty('margin-left', 3) is "200" -PASS layoutTestController.pageProperty('margin-left', 4) is "200" +FAIL layoutTestController.pageProperty('margin-left', 0) should be 200. Was auto. +FAIL layoutTestController.pageProperty('margin-left', 1) should be 200. Was auto. +FAIL layoutTestController.pageProperty('margin-left', 2) should be 200. Was auto. +FAIL layoutTestController.pageProperty('margin-left', 3) should be 200. Was auto. +FAIL layoutTestController.pageProperty('margin-left', 4) should be 200. Was auto. Set margin to 100px. PASS layoutTestController.pageProperty('margin-left', 0) is "100" PASS layoutTestController.pageProperty('margin-left', 1) is "100" Hopefully Aaron will fix it before I owe someone a beer. :)
Attachments
Patch (2.19 KB, patch)
2010-07-09 12:53 PDT, Aaron Boodman 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-08 21:29:05 PDT
I skipped the test in http://trac.webkit.org/changeset/62887 Please remove the test from the skipped list once it passes.
Aaron Boodman
Comment 2 2010-07-08 22:34:33 PDT
Thank you, I will fix this first thing tomorrow.
Aaron Boodman
Comment 3 2010-07-09 12:53:18 PDT
Created attachment 61076 [details] Patch
Aaron Boodman
Comment 4 2010-07-13 11:15:54 PDT
That's weird, I landed this. I don't know why the bug didn't close.
Note You need to log in before you can comment on or make changes to this bug.