RESOLVED FIXED41919
Add NetscapePlugin class 
https://bugs.webkit.org/show_bug.cgi?id=41919
Summary Add NetscapePlugin class
Anders Carlsson
Reported 2010-07-08 17:01:11 PDT
Add NetscapePlugin class
Attachments
Patch (11.26 KB, patch)
2010-07-08 17:03 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-08 17:03:07 PDT
Created attachment 60985 [details] Patch
Sam Weinig
Comment 2 2010-07-08 17:04:41 PDT
Comment on attachment 60985 [details] Patch > + > +namespace WebKit { > + > + > +class NetscapePlugin : public Plugin { Unnecessary whitespace. r=me.
WebKit Review Bot
Comment 3 2010-07-08 17:05:32 PDT
Attachment 60985 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2010-07-14 11:29:51 PDT
Committed r62869: <http://trac.webkit.org/changeset/62869>
Note You need to log in before you can comment on or make changes to this bug.