Bug 41919 - Add NetscapePlugin class
Summary: Add NetscapePlugin class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-08 17:01 PDT by Anders Carlsson
Modified: 2010-07-14 11:29 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.26 KB, patch)
2010-07-08 17:03 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-08 17:01:11 PDT 
Add NetscapePlugin class
Comment 1 Anders Carlsson 2010-07-08 17:03:07 PDT 
Created attachment 60985 [details]
Patch
Comment 2 Sam Weinig 2010-07-08 17:04:41 PDT 
Comment on attachment 60985 [details]
Patch

> +
> +namespace WebKit {
> +
> +    
> +class NetscapePlugin : public Plugin {

Unnecessary whitespace.

r=me.
Comment 3 WebKit Review Bot 2010-07-08 17:05:32 PDT 
Attachment 60985 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2010-07-14 11:29:51 PDT 
Committed r62869: <http://trac.webkit.org/changeset/62869>