Bug 41898 – HTMLImageElement's "complete" attribute should be false for empty images

• Status: RESOLVED
• Resolution: INVALID
• Component: Images

[Andreas Kling]

Quoth HTML5:
"The IDL attribute complete must return true if the user agent has fetched the image specified in the src attribute, and it is in a supported image type (i.e. it was decoded without fatal errors), even if the final task queued by the networking task source for the fetching of the image resource has not yet been processed. Otherwise, the attribute must return false."

This change will fix one in-tree layout test:
- canvas/philip/tests/2d.pattern.image.incomplete.html

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-img-complete

[Andreas Kling]

Created attachment 60951 [details]
Proposed patch

[Darin Adler]

Comment on attachment 60951 [details]
Proposed patch

I just tried this in Firefox:

    javascript:(new Image()).complete

And I got the value "true". It's great to match the HTML5 specification, but I worry that we are moving from matching Firefox to not matching it. Can we discuss this on the WHATWG mailing list before making the change?

[Andreas Kling]

(In reply to comment #2)
> It's great to match the HTML5 specification, but I worry that we are moving from matching Firefox to not matching it. Can we discuss this on the WHATWG mailing list before making the change?

Indeed, we would be the first to implement this behavior. I'll post something to  [whatwg] in a sec.

[Andreas Kling]

Posted on the WHATWG mailing list:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-July/027086.html

[Adam Barth]

Comment on attachment 60951 [details]
Proposed patch

Looks like no one has replied to your message yet.  This patch appears to be blocked on feedback from the working group.  Please feel free to re-nominate for review when we're sure we want to do this.

Is there more motivation for making this change beyond just the spec?

[Andreas Kling]

(In reply to comment #5)
> Is there more motivation for making this change beyond just the spec?

No, that's pretty much it.

Though I personally like that it makes it easy to create an image with complete=false for testing purposes.

[Ian 'Hixie' Hickson]

Note: the spec has changed.

[Darin Adler]

(In reply to comment #7)
> Note: the spec has changed.

Thanks for letting us know. I’ll close this.