Bug 41880 - [Qt] [WebKit2] Make QWKPage call _q_webActionTriggered as a private slot
Summary: [Qt] [WebKit2] Make QWKPage call _q_webActionTriggered as a private slot
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Diego Gonzalez
Keywords: Qt
Depends on:
Reported: 2010-07-08 11:26 PDT by Diego Gonzalez
Modified: 2010-07-09 09:31 PDT (History)
2 users (show)

See Also:

Patch (1.99 KB, patch)
2010-07-08 11:52 PDT, Diego Gonzalez
kenneth: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Gonzalez 2010-07-08 11:26:53 PDT
Make possible to handle the slots for web actions
Comment 1 Diego Gonzalez 2010-07-08 11:52:27 PDT
Created attachment 60919 [details]
Comment 2 WebKit Commit Bot 2010-07-09 08:14:05 PDT
Comment on attachment 60919 [details]

Rejecting patch 60919 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1
Parsed 3 diffs from patch file(s).
patching file WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit2/UIProcess/API/qt/qwkpage.cpp
patching file WebKit2/UIProcess/API/qt/qwkpage.h
Hunk #1 FAILED at 65.
1 out of 1 hunk FAILED -- saving rejects to file WebKit2/UIProcess/API/qt/qwkpage.h.rej

Full output: http://webkit-commit-queue.appspot.com/results/3433053
Comment 3 Diego Gonzalez 2010-07-09 09:31:06 PDT
Landed manually at r62959 https://trac.webkit.org/changeset/62959