RESOLVED FIXED 41872
Allow the TestPlugin to use Core Animation rendering for testing 
https://bugs.webkit.org/show_bug.cgi?id=41872
Summary Allow the TestPlugin to use Core Animation rendering for testing
Simon Fraser (smfr)
Reported 2010-07-08 10:52:57 PDT
It would be great if the TestPlugin could use CA mode, so that we can use it in layout tests.
Attachments
Patch (13.73 KB, patch)
2010-07-08 12:50 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (14.48 KB, patch)
2010-07-08 15:15 PDT, Simon Fraser (smfr) 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-07-08 12:50:31 PDT
Created attachment 60934 [details] Patch
WebKit Review Bot
Comment 2 2010-07-08 12:52:09 PDT
Attachment 60934 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:162: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:164: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:169: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:176: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2010-07-08 15:15:02 PDT
Created attachment 60969 [details] Patch
WebKit Review Bot
Comment 4 2010-07-08 15:17:20 PDT
Attachment 60969 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:163: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:165: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:170: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:177: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 5 2010-07-08 15:37:16 PDT
http://trac.webkit.org/changeset/62857
WebKit Review Bot
Comment 6 2010-07-08 16:11:01 PDT
http://trac.webkit.org/changeset/62857 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/62857 http://trac.webkit.org/changeset/62858
Note You need to log in before you can comment on or make changes to this bug.