Bug 41872 - Allow the TestPlugin to use Core Animation rendering for testing
Summary: Allow the TestPlugin to use Core Animation rendering for testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-08 10:52 PDT by Simon Fraser (smfr)
Modified: 2010-07-08 16:11 PDT (History)
4 users (show)

See Also:


Attachments
Patch (13.73 KB, patch)
2010-07-08 12:50 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (14.48 KB, patch)
2010-07-08 15:15 PDT, Simon Fraser (smfr)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-07-08 10:52:57 PDT
It would be great if the TestPlugin could use CA mode, so that we can use it in layout tests.
Comment 1 Simon Fraser (smfr) 2010-07-08 12:50:31 PDT
Created attachment 60934 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-08 12:52:09 PDT
Attachment 60934 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:162:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:164:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:169:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:176:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2010-07-08 15:15:02 PDT
Created attachment 60969 [details]
Patch
Comment 4 WebKit Review Bot 2010-07-08 15:17:20 PDT
Attachment 60969 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:163:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:165:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:170:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:177:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Simon Fraser (smfr) 2010-07-08 15:37:16 PDT
http://trac.webkit.org/changeset/62857
Comment 6 WebKit Review Bot 2010-07-08 16:11:01 PDT
http://trac.webkit.org/changeset/62857 might have broken Tiger Intel Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/62857
http://trac.webkit.org/changeset/62858