Bug 41863 - Fix adoptRef usage violations (mostly in chromium)
Summary: Fix adoptRef usage violations (mostly in chromium)
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-07-08 08:45 PDT by Vitaly Repeshko
Modified: 2010-07-08 10:50 PDT (History)
3 users (show)

See Also:

patch (10.78 KB, patch)
2010-07-08 08:58 PDT, Vitaly Repeshko
no flags Details | Formatted Diff | Diff
patch v1.1: actually add relax call to IDBDatabaseRequest (10.82 KB, patch)
2010-07-08 09:03 PDT, Vitaly Repeshko
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Repeshko 2010-07-08 08:45:47 PDT
Fix adoptRef usage violations (mostly in chromium)
Comment 1 Vitaly Repeshko 2010-07-08 08:58:05 PDT
Created attachment 60893 [details]
Comment 2 Vitaly Repeshko 2010-07-08 09:03:50 PDT
Created attachment 60896 [details]
patch v1.1: actually add relax call to IDBDatabaseRequest
Comment 3 Vitaly Repeshko 2010-07-08 09:09:48 PDT
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/V8DOMWrapper.cpp
	M	WebCore/bindings/v8/V8NodeFilterCondition.h
	M	WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp
	M	WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp
	M	WebCore/bindings/v8/custom/V8HTMLFormElementCustom.cpp
	M	WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp
	M	WebCore/bindings/v8/custom/V8NamedNodesCollection.h
	M	WebCore/storage/IDBDatabaseRequest.cpp
	M	WebCore/storage/IndexedDatabaseRequest.cpp
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/IDBCallbacksProxy.cpp
	M	WebKit/chromium/src/WebPopupMenuImpl.cpp
	M	WebKit/chromium/src/WebViewImpl.cpp
Committed r62791
Comment 4 Darin Adler 2010-07-08 10:49:57 PDT
It’s best to do this without any calls to relaxOptionRequirement. Instead, code that needs to ref the object can be moved out of constructors into create functions. It’s OK to leave things like this, but better if we could eliminate the relaxAdoptionRequirement calls. Ideally we’d use that only in CrossThreadRefCounted.
Comment 5 Darin Adler 2010-07-08 10:50:30 PDT
Thanks for fixing this all, by the way. I really appreciate it. I think that long-term this adoptRef discipline will help us avoid storage leaks.