RESOLVED FIXED 41863
Fix adoptRef usage violations (mostly in chromium) 
https://bugs.webkit.org/show_bug.cgi?id=41863
Summary Fix adoptRef usage violations (mostly in chromium)
Vitaly Repeshko
Reported Thursday, July 8, 2010 4:45:47 PM UTC
Fix adoptRef usage violations (mostly in chromium)
Attachments
patch (10.78 KB, patch)
2010-07-08 08:58 PDT, Vitaly Repeshko 		no flags
DetailsFormatted DiffDiff
patch v1.1: actually add relax call to IDBDatabaseRequest (10.82 KB, patch)
2010-07-08 09:03 PDT, Vitaly Repeshko 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vitaly Repeshko
Comment 1 Thursday, July 8, 2010 4:58:05 PM UTC
Created attachment 60893 [details] patch
Vitaly Repeshko
Comment 2 Thursday, July 8, 2010 5:03:50 PM UTC
Created attachment 60896 [details] patch v1.1: actually add relax call to IDBDatabaseRequest
Vitaly Repeshko
Comment 3 Thursday, July 8, 2010 5:09:48 PM UTC
M WebCore/ChangeLog M WebCore/bindings/v8/V8DOMWrapper.cpp M WebCore/bindings/v8/V8NodeFilterCondition.h M WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp M WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp M WebCore/bindings/v8/custom/V8HTMLFormElementCustom.cpp M WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp M WebCore/bindings/v8/custom/V8NamedNodesCollection.h M WebCore/storage/IDBDatabaseRequest.cpp M WebCore/storage/IndexedDatabaseRequest.cpp M WebKit/chromium/ChangeLog M WebKit/chromium/src/IDBCallbacksProxy.cpp M WebKit/chromium/src/WebPopupMenuImpl.cpp M WebKit/chromium/src/WebViewImpl.cpp Committed r62791
Darin Adler
Comment 4 Thursday, July 8, 2010 6:49:57 PM UTC
It’s best to do this without any calls to relaxOptionRequirement. Instead, code that needs to ref the object can be moved out of constructors into create functions. It’s OK to leave things like this, but better if we could eliminate the relaxAdoptionRequirement calls. Ideally we’d use that only in CrossThreadRefCounted.
Darin Adler
Comment 5 Thursday, July 8, 2010 6:50:30 PM UTC
Thanks for fixing this all, by the way. I really appreciate it. I think that long-term this adoptRef discipline will help us avoid storage leaks.
Note You need to log in before you can comment on or make changes to this bug.