RESOLVED INVALID41833
VCSUtils::fixChangeLogPatch() should optionally print a warning/move the entry when a new change log entry is not at the top of the change log file 
https://bugs.webkit.org/show_bug.cgi?id=41833
Summary VCSUtils::fixChangeLogPatch() should optionally print a warning/move the entr...
Daniel Bates
Reported 2010-07-07 21:48:47 PDT
Following up on my comment in Bug #41333 <https://bugs.webkit.org/show_bug.cgi?id=41333#c4>, we should have VCSUtils::fixChangeLogPatch() optionally print a warning when a new change log entry is inserted earlier in the change log file. Alternatively, given an optional flag, we may want to forcefully move such an entry to the top of the change log file. It seems rare that someone would want to land a patch with a change log entry located earlier in the change log file either by hand or by the commit-queue.
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2024-02-05 07:47:54 PST
Change Log concept is gone with GitHub migration. So I think it might be clean-up potential, if we still have code here: https://searchfox.org/wubkat/rev/5266b069f715d2051da7f1fc8def26d5dcd5e03c/Tools/Scripts/VCSUtils.pm#1845 Should we close this or we repurpose this?
Sam Sneddon [:gsnedders]
Comment 2 2024-02-05 08:10:49 PST
Let's close this; there's no point in such a warning now. That said, not all of the old ChangeLog code is dead code: we still use a lot of it to generate the changelogs that go into commit messages.
Note You need to log in before you can comment on or make changes to this bug.