41826 – Convert BackForwardList to an abstract base class

Bug 41826 - Convert BackForwardList to an abstract base class

Summary: Convert BackForwardList to an abstract base class

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	History (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC OS X 10.5

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2010-07-07 19:10 PDT by Sam Weinig
Modified:	2010-07-08 09:44 PDT (History)
CC List:	6 users (show)

See Also:

Attachments
Patch (54.26 KB, patch) 2010-07-07 19:12 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Updated patch, don't break Qt. (57.58 KB, patch) 2010-07-07 19:38 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch 3 (once more with a feeling) (57.63 KB, patch) 2010-07-07 19:49 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch 4 (61.14 KB, patch) 2010-07-08 08:51 PDT, Sam Weinig	andersca: review+	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam Weinig 2010-07-07 19:10:32 PDT

Convert BackForwardList to an abstract base class.

Comment 1 Sam Weinig 2010-07-07 19:12:25 PDT

Created attachment 60823 [details]
Patch

Comment 2 Early Warning System Bot 2010-07-07 19:25:19 PDT

Attachment 60823 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/3466003

Comment 3 Sam Weinig 2010-07-07 19:38:33 PDT

Created attachment 60826 [details]
Updated patch, don't break Qt.

Comment 4 Early Warning System Bot 2010-07-07 19:44:05 PDT

Attachment 60826 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/3436007

Comment 5 Sam Weinig 2010-07-07 19:49:49 PDT

Created attachment 60827 [details]
Patch 3 (once more with a feeling)

Comment 6 Darin Fisher (:fishd, Google) 2010-07-07 23:02:38 PDT

Hmm, BackForwardList as an interface makes BackForwardListClient unnecessary.

Comment 7 WebKit Review Bot 2010-07-07 23:08:24 PDT

Attachment 60827 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3473010

Comment 8 Sam Weinig 2010-07-08 08:51:06 PDT

Created attachment 60891 [details]
Patch 4

Comment 9 WebKit Review Bot 2010-07-08 08:52:21 PDT

Attachment 60891 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebhistory.cpp"
WebCore/history/BackForwardListChromium.cpp:29:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 10 Sam Weinig 2010-07-08 08:53:42 PDT

(In reply to comment #6)
> Hmm, BackForwardList as an interface makes BackForwardListClient unnecessary.

Indeed.

Comment 11 Sam Weinig 2010-07-08 09:35:54 PDT

Landed in r62792.

Comment 12 WebKit Review Bot 2010-07-08 09:44:20 PDT

http://trac.webkit.org/changeset/62792 might have broken Chromium Linux Release