RESOLVED FIXED 41826
Convert BackForwardList to an abstract base class 
https://bugs.webkit.org/show_bug.cgi?id=41826
Summary Convert BackForwardList to an abstract base class
Sam Weinig
Reported 2010-07-07 19:10:32 PDT
Convert BackForwardList to an abstract base class.
Attachments
Patch (54.26 KB, patch)
2010-07-07 19:12 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Updated patch, don't break Qt. (57.58 KB, patch)
2010-07-07 19:38 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch 3 (once more with a feeling) (57.63 KB, patch)
2010-07-07 19:49 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch 4 (61.14 KB, patch)
2010-07-08 08:51 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-07 19:12:25 PDT
Created attachment 60823 [details] Patch
Early Warning System Bot
Comment 2 2010-07-07 19:25:19 PDT
Attachment 60823 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3466003
Sam Weinig
Comment 3 2010-07-07 19:38:33 PDT
Created attachment 60826 [details] Updated patch, don't break Qt.
Early Warning System Bot
Comment 4 2010-07-07 19:44:05 PDT
Attachment 60826 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3436007
Sam Weinig
Comment 5 2010-07-07 19:49:49 PDT
Created attachment 60827 [details] Patch 3 (once more with a feeling)
Darin Fisher (:fishd, Google)
Comment 6 2010-07-07 23:02:38 PDT
Hmm, BackForwardList as an interface makes BackForwardListClient unnecessary.
WebKit Review Bot
Comment 7 2010-07-07 23:08:24 PDT
Attachment 60827 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3473010
Sam Weinig
Comment 8 2010-07-08 08:51:06 PDT
Created attachment 60891 [details] Patch 4
WebKit Review Bot
Comment 9 2010-07-08 08:52:21 PDT
Attachment 60891 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebhistory.cpp" WebCore/history/BackForwardListChromium.cpp:29: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 10 2010-07-08 08:53:42 PDT
(In reply to comment #6) > Hmm, BackForwardList as an interface makes BackForwardListClient unnecessary. Indeed.
Sam Weinig
Comment 11 2010-07-08 09:35:54 PDT
Landed in r62792.
WebKit Review Bot
Comment 12 2010-07-08 09:44:20 PDT
http://trac.webkit.org/changeset/62792 might have broken Chromium Linux Release
Note You need to log in before you can comment on or make changes to this bug.