Bug 41798 - Unify Mac and Windows TestNetscapePlugin main.cpp files
Summary: Unify Mac and Windows TestNetscapePlugin main.cpp files
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2010-07-07 14:04 PDT by Anders Carlsson
Modified: 2010-07-07 14:37 PDT (History)
1 user (show)

See Also:

Patch (19.39 KB, patch)
2010-07-07 14:24 PDT, Anders Carlsson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-07 14:04:22 PDT
Unify Mac and Windows TestNetscapePlugin main.cpp files
Comment 1 Anders Carlsson 2010-07-07 14:24:44 PDT
Created attachment 60777 [details]
Comment 2 WebKit Review Bot 2010-07-07 14:27:46 PDT
Attachment 60777 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:152:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-07-07 14:37:22 PDT
Committed r62700: <http://trac.webkit.org/changeset/62700>