Bug 41784 - AX: when a node's role changes, the AX tree might need to be updated
Summary: AX: when a node's role changes, the AX tree might need to be updated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 12:03 PDT by chris fleizach
Modified: 2010-07-07 13:26 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.56 KB, patch)
2010-07-07 12:07 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
Patch (5.09 KB, patch)
2010-07-07 13:24 PDT, chris fleizach 		bdakin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2010-07-07 12:03:22 PDT 
if a role changes for a node, the AX tree might need to be updated because an element's ignored/not ignored status can change.
Comment 1 chris fleizach 2010-07-07 12:07:30 PDT 
Created attachment 60762 [details]
Patch
Comment 2 Beth Dakin 2010-07-07 12:48:36 PDT 
Hey Chris! Is there any way to optimize this so that childrenChanged() is only called when necessary? It seems like it could be a costly operation if it is not needed.
Comment 3 chris fleizach 2010-07-07 12:54:09 PDT 
i think we might be able to limit it to times when accessibilityIsIgnored status changes based on the role change
Comment 4 Beth Dakin 2010-07-07 12:57:36 PDT 
That sounds good!
Comment 5 chris fleizach 2010-07-07 13:24:27 PDT 
Created attachment 60771 [details]
Patch
Comment 6 Beth Dakin 2010-07-07 13:25:10 PDT 
Comment on attachment 60771 [details]
Patch

Yay!
Comment 7 chris fleizach 2010-07-07 13:26:58 PDT 
http://trac.webkit.org/changeset/62694