Bug 41782 - Implement border-start and border-end properties
Summary: Implement border-start and border-end properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Erik Arvidsson
URL: http://dev.w3.org/csswg/css3-text-lay...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 11:49 PDT by Erik Arvidsson
Modified: 2010-07-14 13:09 PDT (History)
7 users (show)

See Also:


Attachments
Patch (19.86 KB, patch)
2010-07-13 11:18 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch (19.97 KB, patch)
2010-07-13 11:30 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2010-07-07 11:49:11 PDT
We currently support padding-start, margin-start and I'm committing support for padding-end and margin-end at the moment.

The proposed CSS3 text layout module also provides:

border-start-width
border-start-style
border-start-color
border-start

as well as the same for end.
Comment 1 Erik Arvidsson 2010-07-13 11:18:02 PDT
Created attachment 61398 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-13 11:19:44 PDT
Attachment 61398 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/css/CSSParser.cpp:804:  One space before end of line comments  [whitespace/comments] [5]
WebCore/css/CSSParser.cpp:810:  One space before end of line comments  [whitespace/comments] [5]
WebCore/css/CSSParser.cpp:811:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Erik Arvidsson 2010-07-13 11:30:22 PDT
Created attachment 61399 [details]
Patch

Fix style issues
Comment 4 WebKit Commit Bot 2010-07-14 12:02:12 PDT
Comment on attachment 61399 [details]
Patch

Clearing flags on attachment: 61399

Committed r63342: <http://trac.webkit.org/changeset/63342>
Comment 5 WebKit Commit Bot 2010-07-14 12:02:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-07-14 13:09:39 PDT
http://trac.webkit.org/changeset/63342 might have broken Chromium Mac Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/63339
http://trac.webkit.org/changeset/63340
http://trac.webkit.org/changeset/63341
http://trac.webkit.org/changeset/63342