WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
41777
Remove needless #include <fcntl.h> from TCSystemAlloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=41777
Summary
Remove needless #include <fcntl.h> from TCSystemAlloc.cpp
Patrick R. Gansterer
Reported
2010-07-07 11:00:49 PDT
see patch
Attachments
Patch
(942 bytes, patch)
2010-07-07 11:01 PDT
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1
2010-07-07 11:01:54 PDT
Created
attachment 60755
[details]
Patch
Darin Adler
Comment 2
2010-07-07 12:28:40 PDT
Comment on
attachment 60755
[details]
Patch It seems that that fcntl.h was needed for O_RDWR, which is used in TryDevMem, but that's no longer compiled in our copy of this file. So it would be slightly better to put <fcntl.h> inside #ifndef WTF_CHANGES, or maybe we should get rid of all the #ifndef WTF_CHANGES entirely.
WebKit Commit Bot
Comment 3
2010-07-08 00:24:11 PDT
Comment on
attachment 60755
[details]
Patch Clearing flags on attachment: 60755 Committed
r62764
: <
http://trac.webkit.org/changeset/62764
>
WebKit Commit Bot
Comment 4
2010-07-08 00:24:15 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug