Bug 41772 - Add basic piping for BackForwardControllerClient
Summary: Add basic piping for BackForwardControllerClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 08:51 PDT by Sam Weinig
Modified: 2010-07-07 09:44 PDT (History)
1 user (show)

See Also:


Attachments
patch (27.72 KB, patch)
2010-07-07 08:57 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-07-07 08:51:31 PDT
Add basic piping for BackForwardControllerClient.
Comment 1 Sam Weinig 2010-07-07 08:57:39 PDT
Created attachment 60738 [details]
patch
Comment 2 WebKit Review Bot 2010-07-07 09:00:23 PDT
Attachment 60738 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/WebProcess/WebCoreSupport/WebBackForwardControllerClient.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp"
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-07-07 09:44:40 PDT
Landed in http://trac.webkit.org/changeset/62676.