WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
41764
[EFL] build fix after
r62577
https://bugs.webkit.org/show_bug.cgi?id=41764
Summary
[EFL] build fix after r62577
Lucas De Marchi
Reported
2010-07-07 06:31:09 PDT
[EFL] build fix after
r62577
Attachments
Patch
(1.53 KB, patch)
2010-07-07 06:34 PDT
,
Lucas De Marchi
no flags
Details
Formatted Diff
Diff
(r62672) Patch
(1.23 KB, patch)
2010-07-07 06:59 PDT
,
Lucas De Marchi
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Lucas De Marchi
Comment 1
2010-07-07 06:34:42 PDT
Created
attachment 60727
[details]
Patch
Antonio Gomes
Comment 2
2010-07-07 06:44:52 PDT
Comment on
attachment 60727
[details]
Patch First, you do not need build for trivial build fixes like this. Go ahead and commit it.
> +2010-07-07 Lucas De Marchi <
lucas.demarchi@profusion.mobi
> > + > + Unreviewed build fix after
r62577
. > + > + [EFL] build fix after
r62577
> +
https://bugs.webkit.org/show_bug.cgi?id=41764
> + > + No new functionality so no new tests. > + > + * CMakeLists.txt: add missing files > + > +2010-07-07 Lucas De Marchi <
lucas.demarchi@profusion.mobi
> > + > + Reviewed by NOBODY (OOPS!). > + > + Unreviewed build fix after
r62577
. > + > + [EFL] build fix after
r62577
> +
https://bugs.webkit.org/show_bug.cgi?id=41764
> + > + No new tests. (OOPS!) > + > + * CMakeLists.txt: > + > 2010-07-07 Antti Koivisto <
koivisto@iki.fi
> > > Reviewed by Kenneth Rohde Christiansen.
You duplicated the ChangeLog entry. Please fix it before committing, though.
Lucas De Marchi
Comment 3
2010-07-07 06:59:33 PDT
Created
attachment 60728
[details]
(
r62672
) Patch
Antonio Gomes
Comment 4
2010-07-07 07:13:12 PDT
Comment on
attachment 60728
[details]
(
r62672
) Patch Lucas, lets thy the CQ first. If it did not commit your build fix until I get a clean tree, I will commit myself.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug