Bug 41764 - [EFL] build fix after r62577
Summary: [EFL] build fix after r62577
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Lucas De Marchi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 06:31 PDT by Lucas De Marchi
Modified: 2010-07-07 08:40 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2010-07-07 06:34 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff
(r62672) Patch (1.23 KB, patch)
2010-07-07 06:59 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2010-07-07 06:31:09 PDT
[EFL] build fix after r62577
Comment 1 Lucas De Marchi 2010-07-07 06:34:42 PDT
Created attachment 60727 [details]
Patch
Comment 2 Antonio Gomes 2010-07-07 06:44:52 PDT
Comment on attachment 60727 [details]
Patch

First, you do not need build for trivial build fixes like this. Go ahead and commit it.

> +2010-07-07  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
> +
> +        Unreviewed build fix after r62577.
> +
> +        [EFL] build fix after r62577
> +        https://bugs.webkit.org/show_bug.cgi?id=41764
> +
> +        No new functionality so no new tests.
> +
> +        * CMakeLists.txt: add missing files
> +
> +2010-07-07  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Unreviewed build fix after r62577.
> +
> +        [EFL] build fix after r62577
> +        https://bugs.webkit.org/show_bug.cgi?id=41764
> +
> +        No new tests. (OOPS!)
> +
> +        * CMakeLists.txt:
> +
>  2010-07-07  Antti Koivisto  <koivisto@iki.fi>
>  
>          Reviewed by Kenneth Rohde Christiansen.

You duplicated the ChangeLog entry. Please fix it before committing, though.
Comment 3 Lucas De Marchi 2010-07-07 06:59:33 PDT
Created attachment 60728 [details]
(r62672) Patch
Comment 4 Antonio Gomes 2010-07-07 07:13:12 PDT
Comment on attachment 60728 [details]
(r62672) Patch

Lucas, lets thy the CQ first. If it did not commit your build fix until I get a clean tree, I will commit myself.