Bug 41759 – Web Inspector: All RefPtr arguments and return values should be changed to PassRefPtr according to common practice.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

In many places in Timeline code RefPtr is using instead of PassRefPtr. 
http://webkit.org/coding/RefPtr.html

[Ilya Tikhonovsky]

Created attachment 60720 [details]
[patch] initial version.

[Ilya Tikhonovsky]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/CodeGeneratorInspector.pm
	M	WebCore/inspector/InspectorTimelineAgent.cpp
	M	WebCore/inspector/InspectorTimelineAgent.h
	M	WebCore/inspector/TimelineRecordFactory.cpp
	M	WebCore/inspector/TimelineRecordFactory.h
Committed r62656

[Joseph Pecoraro]

Thanks for doing this!

[Joseph Pecoraro]

Comment on attachment 60720 [details]
[patch] initial version.

>  $typeTransform{"Object"} = {
> -    "param" => "const RefPtr<InspectorObject>&",
> +    "param" => "PassRefPtr<InspectorObject>",

>  $typeTransform{"Array"} = {
> -    "param" => "const RefPtr<InspectorArray>&",
> +    "param" => "PassRefPtr<InspectorArray>",

This missed $typeTransform{"Value"}.

[Joseph Pecoraro]

Created attachment 60760 [details]
[PATCH] Fix for "Value" Type

[Pavel Feldman]

Comment on attachment 60760 [details]
[PATCH] Fix for "Value" Type

Rubber-stamping on behalf of Ilya.

[Joseph Pecoraro]

Comment on attachment 60760 [details]
[PATCH] Fix for "Value" Type

Landed the follow up in:
Committed r62731
	M	WebCore/ChangeLog
	M	WebCore/inspector/CodeGeneratorInspector.pm
r62731 = d372bb126753aa13b5c79e95dcc4ea24c8a50992 (refs/remotes/trunk)
http://trac.webkit.org/changeset/62731