Bug 41759 - Web Inspector: All RefPtr arguments and return values should be changed to PassRefPtr according to common practice.
Summary: Web Inspector: All RefPtr arguments and return values should be changed to Pa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 05:15 PDT by Ilya Tikhonovsky
Modified: 2010-07-07 17:10 PDT (History)
8 users (show)

See Also:


Attachments
[patch] initial version. (22.99 KB, patch)
2010-07-07 05:30 PDT, Ilya Tikhonovsky
pfeldman: review+
Details | Formatted Diff | Diff
[PATCH] Fix for "Value" Type (1.07 KB, patch)
2010-07-07 11:56 PDT, Joseph Pecoraro
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-07-07 05:15:58 PDT
In many places in Timeline code RefPtr is using instead of PassRefPtr. 
http://webkit.org/coding/RefPtr.html
Comment 1 Ilya Tikhonovsky 2010-07-07 05:30:47 PDT
Created attachment 60720 [details]
[patch] initial version.
Comment 2 Ilya Tikhonovsky 2010-07-07 07:13:01 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/CodeGeneratorInspector.pm
	M	WebCore/inspector/InspectorTimelineAgent.cpp
	M	WebCore/inspector/InspectorTimelineAgent.h
	M	WebCore/inspector/TimelineRecordFactory.cpp
	M	WebCore/inspector/TimelineRecordFactory.h
Committed r62656
Comment 3 Joseph Pecoraro 2010-07-07 09:45:20 PDT
Thanks for doing this!
Comment 4 Joseph Pecoraro 2010-07-07 11:56:31 PDT
Comment on attachment 60720 [details]
[patch] initial version.

>  $typeTransform{"Object"} = {
> -    "param" => "const RefPtr<InspectorObject>&",
> +    "param" => "PassRefPtr<InspectorObject>",

>  $typeTransform{"Array"} = {
> -    "param" => "const RefPtr<InspectorArray>&",
> +    "param" => "PassRefPtr<InspectorArray>",

This missed $typeTransform{"Value"}.
Comment 5 Joseph Pecoraro 2010-07-07 11:56:55 PDT
Created attachment 60760 [details]
[PATCH] Fix for "Value" Type
Comment 6 Pavel Feldman 2010-07-07 12:18:27 PDT
Comment on attachment 60760 [details]
[PATCH] Fix for "Value" Type

Rubber-stamping on behalf of Ilya.
Comment 7 Joseph Pecoraro 2010-07-07 17:10:58 PDT
Comment on attachment 60760 [details]
[PATCH] Fix for "Value" Type

Landed the follow up in:
Committed r62731
	M	WebCore/ChangeLog
	M	WebCore/inspector/CodeGeneratorInspector.pm
r62731 = d372bb126753aa13b5c79e95dcc4ea24c8a50992 (refs/remotes/trunk)
http://trac.webkit.org/changeset/62731