Bug 41753 - [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
Summary: [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 03:04 PDT by Kent Tamura
Modified: 2010-07-08 20:49 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2010-07-07 03:07 PDT, Kent Tamura 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-07-07 03:04:32 PDT 
[DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
Comment 1 Kent Tamura 2010-07-07 03:07:10 PDT 
Created attachment 60712 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-07-07 08:36:02 PDT 
Comment on attachment 60712 [details]
Patch

Sounds good, but please use notImplemented() :)
Comment 3 Kent Tamura 2010-07-07 18:40:50 PDT 
(In reply to comment #2)
> Sounds good, but please use notImplemented() :)

Unfortunately, notImplemented() is a WebCore API.  DRT should not use WebCore API directly.
Comment 4 Dimitri Glazkov (Google) 2010-07-07 18:47:31 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Sounds good, but please use notImplemented() :)
> 
> Unfortunately, notImplemented() is a WebCore API.  DRT should not use WebCore API directly.

Doh! Then LGTM :)
Comment 5 Kent Tamura 2010-07-07 18:52:47 PDT 
Landed as r62740
Comment 6 WebKit Review Bot 2010-07-07 19:15:32 PDT 
http://trac.webkit.org/changeset/62740 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/62739
http://trac.webkit.org/changeset/62740