Bug 41748 - Updating Android to use the UserGestureIndicator class
Summary: Updating Android to use the UserGestureIndicator class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 00:26 PDT by Kristian Monsen
Modified: 2010-07-07 08:01 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch. (2.34 KB, patch)
2010-07-07 00:49 PDT, Kristian Monsen 		no flags Details | Formatted Diff | Diff
Updated patch (whitespace changes) (2.34 KB, patch)
2010-07-07 00:52 PDT, Kristian Monsen 		no flags Details | Formatted Diff | Diff
Proposed patch (Updated Changelog description). (2.34 KB, patch)
2010-07-07 02:05 PDT, Kristian Monsen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kristian Monsen 2010-07-07 00:26:19 PDT 
As a part of a larger fix to remove local changes in Android and use the new UserGestureIndicator class these changes are needed.
Comment 1 Kristian Monsen 2010-07-07 00:49:35 PDT 
Created attachment 60700 [details]
Proposed patch.
Comment 2 Kristian Monsen 2010-07-07 00:52:37 PDT 
Created attachment 60701 [details]
Updated patch (whitespace changes)
Comment 3 Steve Block 2010-07-07 01:50:16 PDT 
Comment on attachment 60701 [details]
Updated patch (whitespace changes)

WebCore/ChangeLog:6
 +          ANDROID_USER_GESTURE. The rest of the changes are removing of local changes or in local only files.
This description should be written from the perspective of WebKit, not Android. So there's no need to mention ANDROID_USER_GESTURE and you should use something like 'parts of the Android port which are yet to be upstreamed' rather than 'local'.
Comment 4 Kristian Monsen 2010-07-07 02:05:24 PDT 
Created attachment 60707 [details]
Proposed patch (Updated Changelog description).
Comment 5 Steve Block 2010-07-07 02:25:12 PDT 
Comment on attachment 60707 [details]
Proposed patch (Updated Changelog description).

r=me
Comment 6 Adam Barth 2010-07-07 02:26:07 PDT 
Comment on attachment 60707 [details]
Proposed patch (Updated Changelog description).

This patch is awesome.  Thanks.  :)
Comment 7 WebKit Commit Bot 2010-07-07 08:01:25 PDT 
Comment on attachment 60707 [details]
Proposed patch (Updated Changelog description).

Clearing flags on attachment: 60707

Committed r62668: <http://trac.webkit.org/changeset/62668>
Comment 8 WebKit Commit Bot 2010-07-07 08:01:29 PDT 
All reviewed patches have been landed.  Closing bug.