WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
41748
Updating Android to use the UserGestureIndicator class
https://bugs.webkit.org/show_bug.cgi?id=41748
Summary
Updating Android to use the UserGestureIndicator class
Kristian Monsen
Reported
2010-07-07 00:26:19 PDT
As a part of a larger fix to remove local changes in Android and use the new UserGestureIndicator class these changes are needed.
Attachments
Proposed patch.
(2.34 KB, patch)
2010-07-07 00:49 PDT
,
Kristian Monsen
no flags
Details
Formatted Diff
Diff
Updated patch (whitespace changes)
(2.34 KB, patch)
2010-07-07 00:52 PDT
,
Kristian Monsen
no flags
Details
Formatted Diff
Diff
Proposed patch (Updated Changelog description).
(2.34 KB, patch)
2010-07-07 02:05 PDT
,
Kristian Monsen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Kristian Monsen
Comment 1
2010-07-07 00:49:35 PDT
Created
attachment 60700
[details]
Proposed patch.
Kristian Monsen
Comment 2
2010-07-07 00:52:37 PDT
Created
attachment 60701
[details]
Updated patch (whitespace changes)
Steve Block
Comment 3
2010-07-07 01:50:16 PDT
Comment on
attachment 60701
[details]
Updated patch (whitespace changes) WebCore/ChangeLog:6 + ANDROID_USER_GESTURE. The rest of the changes are removing of local changes or in local only files. This description should be written from the perspective of WebKit, not Android. So there's no need to mention ANDROID_USER_GESTURE and you should use something like 'parts of the Android port which are yet to be upstreamed' rather than 'local'.
Kristian Monsen
Comment 4
2010-07-07 02:05:24 PDT
Created
attachment 60707
[details]
Proposed patch (Updated Changelog description).
Steve Block
Comment 5
2010-07-07 02:25:12 PDT
Comment on
attachment 60707
[details]
Proposed patch (Updated Changelog description). r=me
Adam Barth
Comment 6
2010-07-07 02:26:07 PDT
Comment on
attachment 60707
[details]
Proposed patch (Updated Changelog description). This patch is awesome. Thanks. :)
WebKit Commit Bot
Comment 7
2010-07-07 08:01:25 PDT
Comment on
attachment 60707
[details]
Proposed patch (Updated Changelog description). Clearing flags on attachment: 60707 Committed
r62668
: <
http://trac.webkit.org/changeset/62668
>
WebKit Commit Bot
Comment 8
2010-07-07 08:01:29 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug