Bug 4174 - DOM layout tests involving two documents fail due to test framework problem
Summary: DOM layout tests involving two documents fail due to test framework problem
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 412
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Vicki Murley
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-27 23:15 PDT by Curt Arnold
Modified: 2005-08-10 18:09 PDT (History)
0 users

See Also:


Attachments
Patch file with new selfhtml.js files and -expected.txt files. (23.65 KB, patch)
2005-07-27 23:16 PDT, Curt Arnold
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Curt Arnold 2005-07-27 23:15:09 PDT
The self-hosted W3C DOM test suite had an dependency on the implementation-specific behavior of 
Document.cloneNode(true) which causes about 20 tests to report erroneous failures.   See last 
paragraph of http://www.opendarwin.org/pipermail/webkit-dev/2005-July/000329.html

This has been reported and fixed in the W3C CVS as http://www.w3.org/Bugs/Public/show_bug.cgi?
id=1821.  The resolution was to add fallback code that would attempt to do a brute force copy of the 
document.  The resulting code will work properly with IE 6, Mozilla, Opera and Safari.

The patch adds the new code to the various copies of selfhtml.js in the layout tests (and updates 
level2/events/selfhtml.js which was using an earlier copy).  The Webkit modifications to the W3C 
original are preserved and identified as required by the W3C license.

The patch includes changes to -expected.txt files.  Running run-webkit-tests was observed to result in 
a broken pipe on some runs, however the failing test was inconsistent and did not occur last time run.
Comment 1 Curt Arnold 2005-07-27 23:16:17 PDT
Created attachment 3133 [details]
Patch file with new selfhtml.js files and -expected.txt files.
Comment 2 Vicki Murley 2005-08-10 18:09:44 PDT
committed this to our tree