Bug 41726 – Expose URL matching from WebUserContentURLPattern

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Steve Falkenburg]

Expose URL matching from WebUserContentURLPattern

[Steve Falkenburg]

Created attachment 60667 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 60667 [details]
Patch

> Index: WebCore/ChangeLog
> ===================================================================

> +        Expose URL matching from WebUserContentURLPattern
> +        https://bugs.webkit.org/show_bug.cgi?id=41726
> +
> +        No new tests. (OOPS!)

You should remove this line.

> Index: WebKit/mac/ChangeLog
> ===================================================================
> --- WebKit/mac/ChangeLog	(revision 62607)
> +++ WebKit/mac/ChangeLog	(working copy)
> @@ -1,3 +1,14 @@
> [phone]  Steve Falkenburg  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Expose URL matching from WebUserContentURLPattern
> +        https://bugs.webkit.org/show_bug.cgi?id=41726
> +
> +        * Misc/WebUserContentURLPattern.h:
> +        * Misc/WebUserContentURLPattern.mm:
> +        (-[WebUserContentURLPattern matchesURL:]):

I would like to see a few words about the change.

> Index: WebKit/win/ChangeLog
> ===================================================================

> +        Expose URL matching from WebUserContentURLPattern
> +        https://bugs.webkit.org/show_bug.cgi?id=41726
> +
> +        * Interfaces/IWebUserContentURLPattern.idl:
> +        * Interfaces/IWebView.idl:
> +        * WebUserContentURLPattern.cpp:
> +        (WebUserContentURLPattern::matchesURL):
> +        * WebUserContentURLPattern.h:

You could explain the whitespace change to the idl file here at least.

r=me

[Steve Falkenburg]

http://trac.webkit.org/changeset/62625