Bug 41725 - REGRESSION(r62283): No longer possible to build for Tiger from SnowLeopard due to export file shenanigans
Summary: REGRESSION(r62283): No longer possible to build for Tiger from SnowLeopard du...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.6
: P2 Normal
Assignee: Mark Rowe (bdash)
Keywords: Regression
Depends on:
Reported: 2010-07-06 17:18 PDT by Mark Rowe (bdash)
Modified: 2010-07-06 18:13 PDT (History)
2 users (show)

See Also:

Patch (63.19 KB, patch)
2010-07-06 17:45 PDT, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff
Patch (64.51 KB, patch)
2010-07-06 17:50 PDT, Mark Rowe (bdash)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2010-07-06 17:18:54 PDT
In <http://trac.webkit.org/changeset/62283> an export file was added containing symbols that are only available when USE(ACCELERATED_COMPOSITING) is true.  However, the manner in which it detects USE(ACCELERATED_COMPOSITING) being true only considers the build OS, not the OS that is being targeted.  This results in WebCore failing to link when building for Tiger from SnowLeopard as the symbols from the accelerated compositing exports file are not present in any of the object files.

This makes it impossible to build WebKit nightlies for Mac OS X.
Comment 1 Mark Rowe (bdash) 2010-07-06 17:21:32 PDT
In order to address the more general issue here we need the selection of which symbols to export to follow the same logic that is used by the compiler when determining which features are enabled.  One way to do this is to have the generation of the exports file handled via C++ code that uses the regular preprocessor macros to include or exclude symbols.  Iā€™m working on a patch that does just that.
Comment 2 Mark Rowe (bdash) 2010-07-06 17:45:26 PDT
Created attachment 60665 [details]

I'm not marking this for review quite yet as I'm still waiting on a build for Tiger from SnowLeopard to complete.  I tested more normal build configurations successfully, and have eyeballed the output as well and everything looks correct.
Comment 3 Mark Rowe (bdash) 2010-07-06 17:50:05 PDT
Created attachment 60666 [details]
Comment 4 Mark Rowe (bdash) 2010-07-06 18:02:03 PDT
Landed in r62608.
Comment 5 Eric Seidel (no email) 2010-07-06 18:02:06 PDT
Attachment 60666 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/3370400
Comment 6 Mark Rowe (bdash) 2010-07-06 18:13:53 PDT
A follow-up build fix was landed in r62609.